Relax protobuf minimum version dependency to 3.0.0#48
Merged
Conversation
Kyle-Verhoog
force-pushed
the
protobuf-min
branch
5 times, most recently
from
April 7, 2022 23:04
ffd6b14 to
c34d0d9
Compare
Kyle-Verhoog
changed the title
Kyle-Verhoog
force-pushed
the
protobuf-min
branch
3 times, most recently
from
April 7, 2022 23:12
cce1eb3 to
65c2404
Compare
24 tasks
Kyle-Verhoog
marked this pull request as ready for review
April 8, 2022 00:59
brettlangdon
approved these changes
Apr 8, 2022
brettlangdon
left a comment
brettlangdon
left a comment
Member
There was a problem hiding this comment.
any particular reason to do 3.6.0?
any blockers for supporting >= 3.0 ?
Member
Author
|
Yeah there's a bit more context here as the PR evolved as I tried going as far back as possible, I'll update the PR description. |
Kyle-Verhoog
force-pushed
the
protobuf-min
branch
from
April 8, 2022 15:00
65c2404 to
9a1f10c
Compare
Kyle-Verhoog
changed the title
Member
Author
|
I was able to get 3.0 working quite easily thanks to @jd so we might as well just match |
Kyle-Verhoog
force-pushed
the
protobuf-min
branch
from
April 8, 2022 15:03
9a1f10c to
e09c198
Compare
brettlangdon
reviewed
Apr 8, 2022
The minimum version seems to be pretty arbitrarily picked so might as well go back a bit further to match the minimum version that `ddtrace` supports.
Kyle-Verhoog
force-pushed
the
protobuf-min
branch
from
April 8, 2022 15:12
e09c198 to
13d59f6
Compare
brettlangdon
approved these changes
Apr 8, 2022
jd
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum version seems to be pretty arbitrarily picked so might as
well go back a bit further to match that of
ddtrace.