PANA-5615: Fix permanent_id property ordering for Android compatibility#356
Merged
gonzalezreal merged 1 commit intoFeb 24, 2026
Merged
Conversation
nguyexua
approved these changes
Feb 23, 2026
0xnm
approved these changes
Feb 24, 2026
gonzalezreal
deleted the
gonzalezreal/PANA-5615/permanent-id-property-ordering
branch
February 24, 2026 10:56
Merged
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the positional ordering of
permanentId/permanent_idin the JSON schemas to ensure Android code generation produces backwards-compatible constructor signatures.This change is safe since
permanentId/permanent_idis not yet used in production by any platform.Changes
permanent_idto the end of the target properties inaction-schema.json(after width and height)permanentIdfrom_common-wireframe-schema.jsonand added it as the last property in each leaf wireframe schema:ShapeWireframeTextWireframeImageWireframePlaceholderWireframeWebviewWireframeContext
Android uses the schema JSON positionally when generating constructor signatures. Because wireframe schemas use
allOfto extend from common schemas, havingpermanentIdin_common-wireframe-schema.jsoncaused it to appear in the middle of the generated argument lists, breaking backwards compatibility.Moving it to the end of each leaf node ensures it's always last in the generated signatures.