Skip to content

RUM-12387: Add android sdk schema generator check#334

Merged
aleksandr-gringauz merged 1 commit into
masterfrom
aleksandr-gringauz/RUM-12387/android-sdk-check-develop
Jan 7, 2026
Merged

RUM-12387: Add android sdk schema generator check#334
aleksandr-gringauz merged 1 commit into
masterfrom
aleksandr-gringauz/RUM-12387/android-sdk-check-develop

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Introducing a CI check for Android SDK similar to what already exists for iOS.

This check:

  1. Clones dd-sdk-android repo.
  2. Makes it use the RUM schema from the current branch of rum-events-format repo.
  3. Generates all JSON serialization/deserialization code.

Implementation details:

  1. A successful run of the check can be found here. This run uses a branch of dd-sdk-android repo from this PR. It needs to be merged first before the current PR in rum-events-format repo is merged.
  2. As the Android generator code is inside the main Gradle project it requires Java, Android SDK and Android NDK to run any Gradle command.
  3. Android SDK is already present in ubuntu-latest images link. Currently dd-sdk-android needs platform-36, build-tools 36.0.0 which are already there. But we still ask Android SDK manager to install them in case ubuntu-latest image changes.
  4. Java 17 is configured using the Github supported action. This action is also needed to configure Gradle dependencies cache.
  5. The version of NDK that dd-sdk-android needs is 28.0.13004108. Is isn't preinstalled on the ubuntu-latest image. So we install it using Android SDK Manager and cache it using GitHub cache so that it isn't downloaded every time. You can see a successful cache hit here.

@aleksandr-gringauz

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/android-sdk.yml Outdated
@aleksandr-gringauz
aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12387/android-sdk-check-develop branch from 52d6360 to 8e520f2 Compare January 2, 2026 13:15
@aleksandr-gringauz

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review January 2, 2026 13:19
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners January 2, 2026 13:19

@BenoitZugmeyer BenoitZugmeyer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksandr-gringauz
aleksandr-gringauz merged commit d555ad8 into master Jan 7, 2026
15 of 16 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/RUM-12387/android-sdk-check-develop branch January 7, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants