Add RUM Profiler data model to rum-events-format#325
Conversation
| "title": "ProfileEventPayload", | ||
| "type": "object", | ||
| "description": "Schema of the Profile Event payload.", | ||
| "required": ["event", "wall-time.json"], |
There was a problem hiding this comment.
strictly speaking, Mobile SDKs don't have wall-time.json, but at the same time event is passed in the multipart-form format, next to the recording binary unlike in case of Browser SDK
There was a problem hiding this comment.
I see, should I remove this ProfileEventPayload as it's too platform-specific?
There was a problem hiding this comment.
In the browser, the event is also sent as multipart form data, alongside the profiler trace binary. The backend does not expect a ProfileEventPayload type. We should remove it.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Discussed this build failure for android-sdk with @BeltranBulbarellaDD . TL;DR. Kotlin Poet can't create a class with field name In the current CI run our session replay module fetched new profiling schema files and started checking them. I'll fix it. IIUC |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This PR adds the Profiling data model, making it consistent with RUM and Session Replay Schema.
Structure:
browser/profile-event-schema.json: Browser-specific payload schema extending_common-schema.jsonwith browser-specific fields (format, _dd.clock_drift) and the wall-time trace.mobile/profile-event-schema.json: Mobile-specific profile event extending_common-schema.jsonwith the vital property.Samples where taken from the test:performance e2e test in
Browser-SDKrepoIn this Browser PR we can see how they will be used.