-
Notifications
You must be signed in to change notification settings - Fork 8
♻️ Reorganize rum schemas to work around optional "view" property issues #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
003ff7a
🔥 remove unused _dd.vital.computed_value field
BenoitZugmeyer 931b023
🚚 rename "feature operation" to "operation step"
BenoitZugmeyer bc6b8d7
♻️ refactor Vital events to make them more independent
BenoitZugmeyer 8184858
🔥 remove unused schema entrypoints
BenoitZugmeyer f234db9
♻️ separate browser and mobile rum events
BenoitZugmeyer f0aac48
🏷️ make 'view' property required for TS
BenoitZugmeyer e505ab9
🚨 add a validation check for required properties
BenoitZugmeyer 415b2d2
👌 review suggestion: improve required 'view' property definition
BenoitZugmeyer 9f293f3
Bring back the json schema entrypoints used by the iOS SDK
BenoitZugmeyer 8743014
Merge remote-tracking branch 'origin/master' into benoit/reorganize-r…
BenoitZugmeyer 3837aa1
Revert "👌 review suggestion: improve required 'view' property definit…
BenoitZugmeyer 220d90b
👌 use `oneOf` instead of `anyOf`
BenoitZugmeyer 8421e11
👌 modify entrypoints consumed by the iOS SDK
BenoitZugmeyer 616a1b8
👌 fix README typos
BenoitZugmeyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Question : Why this property is not optional anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch. This happened when I did this change. I think the intent was to make it required but it never worked (at least with
json-schema-to-typescript). Let's wait for a Mobile review to know more.