RUM-11595: Extend Vital event to App Launch metrics#302
Merged
simaoseica-dd merged 1 commit intoSep 11, 2025
Merged
Conversation
simaoseica-dd
force-pushed
the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
4 times, most recently
from
September 8, 2025 13:29
e08ef0b to
8d29d80
Compare
simaoseica-dd
requested review from
BenoitZugmeyer,
Matthieu-Z,
cy-moi,
louisj-dd,
mariedm and
satween
September 8, 2025 15:29
BenoitZugmeyer
left a comment
Member
There was a problem hiding this comment.
Suggestion: add a vital-duration-schema.json, and define a required duration property there. I think the duration property isn't relevant for feature operation so you could remove it from the "common" schema and declare it where it makes sense
Suggestion: move the vital.type in their respective schemas and use oneOf between schemas. It could focus on the vital namespace, and either inherit a "common vital" schema for each type of vital or just do something like:
"vital": {
"description": "Vital properties",
"allOf": [
{
"type": "object",
"required": ["id", "type"],
"properties": {
"id": {
"type": "string",
"description": "UUID of the vital",
"pattern": "^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}$",
"readOnly": true
},
"name": {
"type": "string",
"description": "Name of the vital, as it is also used as facet path for its value, it must contain only letters, digits, or the characters - _ . @ $",
"readOnly": true
},
"description": {
"type": "string",
"description": "Description of the vital. It can be used as a secondary identifier (URL, React component name...)",
"readOnly": true
}
},
"readOnly": true
},
{
"oneOf": [
{
"$ref": "vital-duration-schema.json"
},
{
"$ref": "vital-app-launch-schema.json"
},
{
"$ref": "vital-feature-operations-schema.json"
}
]
}
],
"readOnly": true
},
simaoseica-dd
force-pushed
the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
3 times, most recently
from
September 9, 2025 12:34
2b1b75e to
16dc13b
Compare
Contributor
Author
|
@BenoitZugmeyer Thank you for the suggestion. The contexts are now truly split with the |
simaoseica-dd
force-pushed
the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
from
September 9, 2025 15:12
16dc13b to
aa11114
Compare
cy-moi
reviewed
Sep 9, 2025
cy-moi
reviewed
Sep 9, 2025
mariedm
previously approved these changes
Sep 9, 2025
simaoseica-dd
force-pushed
the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
3 times, most recently
from
September 9, 2025 17:32
cc8e477 to
81a205a
Compare
simaoseica-dd
force-pushed
the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
from
September 11, 2025 09:43
81a205a to
b2dcc47
Compare
simaoseica-dd
force-pushed
the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
from
September 11, 2025 10:09
b2dcc47 to
f97f9a2
Compare
simaoseica-dd
requested review from
BenoitZugmeyer,
aleksandr-gringauz,
cy-moi and
mariedm
September 11, 2025 10:22
cy-moi
approved these changes
Sep 11, 2025
barboraplasovska
approved these changes
Sep 11, 2025
hemeryar
approved these changes
Sep 11, 2025
BenoitZugmeyer
approved these changes
Sep 11, 2025
simaoseica-dd
deleted the
simaoseica/RUM-11595/extend-vital-event-to-app-launch-metrics
branch
September 11, 2025 13:04
4 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes extending the Vital schema to other features.
Currently, the Vital schema includes some "Feature Operations" parameters. Since the "App Launch" initiative is leveraging vitals, it makes sense to design the schema with scalability in mind.
It introduces new sub schemas of the common
vital-common-schema.json:vital-duration-schema.json- Focused on duration properties. It is isolated because Feature Operations doesn't have duration.vital-app-launch-schema.json- Focused on App launch metrics.vital-feature-operations-schema.json- Focused on Feature Operations.