Address AllowedPaths follow-up nits#541
Merged
Merged
Conversation
|
matt-dz
marked this pull request as ready for review
June 24, 2026 13:42
matt-dz
requested review from
AlexandreYang,
astuyve,
julesmcrt,
thieman and
val06
as code owners
June 24, 2026 13:42
matt-dz
enabled auto-merge
June 24, 2026 13:43
julesmcrt
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small follow-up to address review nits that came up on #271 before it was merged.
--allowed-pathshelp text to mentionPATH[:ro|:rw], including the default read-only behavior.--mode remediationhelp text so it names:rwAllowedPaths roots.:ro/:rwsuffix interpretation, including the intentional ADS-style ambiguity tradeoff versus Unix literal-path preservation.allowedpathsanalysis symbol allowlist.Impact
No runtime sandbox behavior changes are intended. This keeps user-facing help, docs, comments, and review-maintained allowlist ordering aligned with the merged AllowedPaths mode work.
Validation
make fmtgo test ./cmd/rshellgo run ./cmd/rshell --helpgo test ./allowedpathsGOOS=windows go test -c ./allowedpaths -o /tmp/rshell-allowedpaths-windows.test.exego test ./analysisgit diff --check