feat(interp): add RemediationMode() RunnerOption [PR A]#524
Merged
Conversation
… series) Adds `RemediationMode() RunnerOption`, the `remediationMode bool` field on `runnerConfig`, the `--remediation-mode` CLI flag, and one-line docs in README.md / SHELL_FEATURES.md. The option is accepted without error and stored on the runner, but is otherwise inert — no behavior changes in this PR. Write capability and interpreter wiring follow in PRs B and C. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Collaborator
Author
|
@codex review |
1 similar comment
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
julesmcrt
marked this pull request as ready for review
June 10, 2026 11:28
julesmcrt
requested review from
AlexandreYang,
astuyve,
matt-dz,
thieman and
val06
as code owners
June 10, 2026 11:28
…remediation Per review feedback, a string enum is more extensible than a per-mode boolean flag. The default is read-only (existing behavior); passing --mode remediation enables remediation mode. Invalid values are rejected with a clear error message. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
3 tasks
AlexandreYang
approved these changes
Jun 11, 2026
| allowedCommands []string | ||
| allowAllCommands bool | ||
| procPath string | ||
| remediationMode bool |
Member
There was a problem hiding this comment.
can/shall we align also remediationMode ?
instead of remediationMode have mode: <read-only | remediation>
with struct types ModeReadOnly and ModeRemediation that can be used by datadog-agent (client)
Collaborator
Author
There was a problem hiding this comment.
Done — added an exported Mode type with ModeReadOnly and ModeRemediation constants to the interp package. executeOpts now carries an interp.Mode field, and the CLI parses the --mode string against those constants. Agent clients can import the type directly.
…n constants Per review feedback, align executeOpts with the --mode flag by replacing the internal remediationMode bool with an interp.Mode field. Define the Mode type and its constants in the interp package so datadog-agent clients can reference them directly without stringly-typed comparisons. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
4 tasks
julesmcrt
added a commit
that referenced
this pull request
Jun 16, 2026
PR #524 reviewer explicitly asked for type Mode with ModeReadOnly and ModeRemediation constants. PR #526 had renamed the type to ExecutionMode to avoid a naming conflict with the Mode() RunnerOption function, but that went against the prior review feedback. Restore type Mode string (as requested in PR #524) and rename the RunnerOption from Mode() to WithMode(), which reads naturally at the call site (interp.WithMode(interp.ModeRemediation)) and eliminates the awkward inversion where the setter and the type had swapped names. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemediationMode() RunnerOptionininterp/api.gowith the correspondingremediationMode boolfield onrunnerConfig--remediation-modeboolean CLI flag (defaultfalse) incmd/rshell/main.goREADME.mdandSHELL_FEATURES.md(one line each)This PR is purely an API addition — no behavior changes. The option is accepted and stored on the runner but is otherwise inert.
Context (multi-PR series)
RemediationMode()option — API only, inertallowedpaths/sandbox.goremediationModeinto interpreter so>/>>redirects work when settruncateandlogrotatebuiltinsEnd goal: a
runRemediationCommandPAR action creates aRunnerwithRemediationMode()set; the existingrunCommandaction does not.Test plan
go build ./...— cleango test ./...— all passmake fmt— no changes after formatting