fix(help): list while/until as supported in help output#242
Merged
Conversation
The control-flow feature description and unsupported-summary advertised while and until loops as unsupported, but the interpreter has supported both for some time (and SHELL_FEATURES.md already documents them as supported). Move them from Unsupported to Supported and update the pinned strings in help_test.go and the unrestricted help scenario.
AlexandreYang
marked this pull request as ready for review
May 8, 2026 08:27
AlexandreYang
requested review from
astuyve,
julesmcrt,
matt-dz,
thieman and
val06
as code owners
May 8, 2026 08:27
Member
Author
|
@codex review |
astuyve
approved these changes
May 11, 2026
Collaborator
|
codex is gonna say it's good |
For each Supported/Unsupported item in the four syntactic features (variables, control-flow, pipes-redirections, quoting-expansion), run a canonical one-line script through the interpreter and assert: - Supported items must NOT produce a "not supported" rejection. - Unsupported items MUST produce one AND exit non-zero. The probe map is keyed by the exact item string from featureRegistry, so adding or rewording an entry without supplying a probe fails the test — forcing future contributors to keep help and implementation in lockstep. Verified that the test fails on the pre-fix help text: "missing probe for unsupported item 'while and until loops.'".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control-flowfeature inhelpadvertisedwhileanduntilas unsupported, but the interpreter actually supports both (andSHELL_FEATURES.mdalready documents them as ✅).X=0; while [ "$X" != stop ]; do echo iter; X=stop; doneagainst the built binary — they iterate normally and exit 0.control-flow, refreshed the feature one-liner (for/while/until/if/...; no case/select/functions.), and droppedwhile/untilfrom the top-level unsupported summary.builtins/tests/help/help_test.goandtests/scenarios/cmd/help/unrestricted.yamlso they assert the new wording.All other commands and features listed in
helpwere verified to be present (33 commands, 8 features) — this was the only mismatch.Test plan
go test ./builtins/... ./tests/...(passes locally)make fmtcleanrshell -c 'help control-flow'showswhile/untilunder Supportedrshell -c 'help'summary no longer claimswhile/untilis unsupported