ddprof fix the inlining test#48
Merged
Merged
Conversation
Collaborator
Author
|
this will be KO until we merge this. |
r1viollet
force-pushed
the
r1viollet/ddprof_inlining_test_fix
branch
from
March 11, 2025 09:11
0c58a81 to
f2452fd
Compare
nsavoire
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The inlining test was incomplete.
This adds an intermediate function to test the order of the inlined functions.
It also activates the inlining parameter in ddprof, which was previously not triggered.