chore: migrate DD_K9_LIBRARY_GO_APP_PRIVATE_KEY to dd-octo-sts#816
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
github-actions
Bot
added
the
conventional-commit/chore
RamyElkest
marked this pull request as ready for review
April 2, 2026 23:21
This comment has been minimized.
This comment has been minimized.
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
## Summary **Part 1 of 2** — adds trust policies only. Merge this first. Adds dd-octo-sts trust policies to prepare for migrating `deps-update.yml` and `validate.yml` workflows from `DD_K9_LIBRARY_GO_APP_PRIVATE_KEY` to OIDC-federated tokens. ### Why split into two PRs? dd-octo-sts reads trust policies from the **target repo's default branch**. If we ship the policies and workflow changes together, the workflow changes can't be tested on the PR itself — the policies aren't on `main` yet. By merging policies first, the second PR's CI can exercise the new dd-octo-sts token exchange. ### Policies added | Policy file | Workflow | Events | Permissions | |---|---|---|---| | `self.github.deps-update.schedule.sts.yaml` | `deps-update.yml` / create-pr | schedule, dispatch | `contents: write`, `pull_requests: write` | | `self.github.validate.self-mutation.sts.yaml` | `validate.yml` / self-mutation | pull_request | `contents: write` | Both are self-referential policies (orchestrion writing to itself). These are needed because: - `deps-update` creates PRs — disallowed for `GITHUB_TOKEN` per org policy - `self-mutation` pushes commits that must re-trigger CI — `GITHUB_TOKEN` pushes don't trigger workflow runs ### Next step After this merges → #816 migrates the workflows. ## Test plan - [ ] Trust Policy Validation CI check passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Jira: APPSEC-62083 Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
eliottness
force-pushed
the
ramy.elkest/migrate-dd-octo-sts-workflows
branch
from
April 3, 2026 10:21
6d318bc to
8151c6b
Compare
eliottness
enabled auto-merge
April 3, 2026 10:25
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
+ Coverage 65.72% 70.82% +5.10%
==========================================
Files 113 116 +3
Lines 7926 6900 -1026
==========================================
- Hits 5209 4887 -322
+ Misses 2192 1442 -750
- Partials 525 571 +46
🚀 New features to boost your workflow:
|
eliottness
approved these changes
Apr 7, 2026
Replace actions/create-github-app-token with dd-octo-sts-action for OIDC-federated short-lived tokens in deps-update and validate workflows. Depends on the trust policies from the parent PR being merged first — dd-octo-sts reads policies from the target repo's default branch. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
eliottness
force-pushed
the
ramy.elkest/migrate-dd-octo-sts-workflows
branch
from
April 7, 2026 09:19
8151c6b to
bafdf87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of 2 — depends on #815 (trust policies) being merged first.
Replaces
actions/create-github-app-tokenwithDataDog/dd-octo-sts-actionfor OIDC-federated short-lived tokens, eliminating the dependency on the sharedDD_K9_LIBRARY_GO_APP_PRIVATE_KEYsecret.Why this depends on #815
dd-octo-sts reads trust policies from the target repo's default branch. The policies from #815 must be on
mainbefore this PR's workflows can exchange OIDC tokens. Once #815 merges, theself-mutationjob on this PR can exercise the new token exchange.Workflows migrated
deps-update.ymlcreate-prghcommit-actionsigned commits +gh pr createvalidate.ymlself-mutationghcommit-actionsigned commitsChanges
actions/create-github-app-token→DataDog/[email protected](SHA-pinned)id-token: writeto job permissions (required for OIDC exchange)pull-requests: writefromdeps-updatejob permissions (now handled by dd-octo-sts token)Test plan
self-mutationshould work on this PR ifgo generateproduces changesdeps-update.ymlviaworkflow_dispatch🤖 Generated with Claude Code
Jira: APPSEC-62083