Skip to content

fix(internal/ensure): Do not fail hard when the submodule does not exist#736

Merged
kakkoyun merged 1 commit into
mainfrom
kakkoyun/fix_missing_integration
Oct 28, 2025
Merged

fix(internal/ensure): Do not fail hard when the submodule does not exist#736
kakkoyun merged 1 commit into
mainfrom
kakkoyun/fix_missing_integration

Conversation

@kakkoyun

@kakkoyun kakkoyun commented Oct 27, 2025

Copy link
Copy Markdown
Member

Signed-off-by: Kemal Akkoyun [email protected]

Fixes #732

@kakkoyun
kakkoyun force-pushed the kakkoyun/fix_missing_integration branch from 0106dd3 to f7daa7d Compare October 28, 2025 12:52
@kakkoyun
kakkoyun marked this pull request as ready for review October 28, 2025 12:54
@kakkoyun
kakkoyun requested a review from a team as a code owner October 28, 2025 12:54
@kakkoyun
kakkoyun enabled auto-merge October 28, 2025 12:55

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakkoyun
kakkoyun added this pull request to the merge queue Oct 28, 2025
auto-merge was automatically disabled October 28, 2025 13:37

Pull Request is not mergeable

auto-merge was automatically disabled October 28, 2025 13:37

Pull Request is not mergeable

Merged via the queue into main with commit f297591 Oct 28, 2025
118 of 120 checks passed
@kakkoyun
kakkoyun deleted the kakkoyun/fix_missing_integration branch October 28, 2025 13:50
@codecov

codecov Bot commented Oct 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.17%. Comparing base (e061d12) to head (f7daa7d).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
internal/ensure/requiredintegrations.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   65.72%   68.17%   +2.45%     
==========================================
  Files         113      116       +3     
  Lines        7926     6891    -1035     
==========================================
- Hits         5209     4698     -511     
+ Misses       2192     1641     -551     
- Partials      525      552      +27     
Components Coverage Δ
Generators 83.23% <ø> (+2.98%) ⬆️
Instruments ∅ <ø> (∅)
Go Driver 75.37% <65.38%> (-0.44%) ⬇️
Toolexec Driver 72.34% <100.00%> (+4.81%) ⬆️
Aspects 74.70% <76.37%> (+2.79%) ⬆️
Injector 75.14% <77.04%> (+2.35%) ⬆️
Job Server 67.50% <55.55%> (+1.58%) ⬆️
Other 68.17% <64.89%> (+2.45%) ⬆️
Files with missing lines Coverage Δ
internal/ensure/requiredintegrations.go 80.67% <75.00%> (ø)

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Orchestrion pin v1.6.0

3 participants