fix: flags only partially processed#701
Merged
Merged
Conversation
When using `go test` and providing the test package set before some flag, the subsequent flags were not correctly processed, resulting in particular in the `-coverpkg` flag not being appropriately expanded when necessary. This resulted in relative patterns being passed to child builds which is the cause of some build ID mismatch errors. This was caused by an incorrect assumption that all `go` building commands demand flags are presented before any positional argument, which is at least not true for `go test` (and likely also for `go run`).
eliottness
approved these changes
Sep 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 65.72% 67.06% +1.34%
==========================================
Files 113 114 +1
Lines 7926 8040 +114
==========================================
+ Hits 5209 5392 +183
+ Misses 2192 2128 -64
+ Partials 525 520 -5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
go testand providing the test package set before some flag, the subsequent flags were not correctly processed, resulting in particular in the-coverpkgflag not being appropriately expanded when necessary. This resulted in relative patterns being passed to child builds which is the cause of some build ID mismatch errors.This was caused by an incorrect assumption that all
gobuilding commands demand flags are presented before any positional argument, which is at least not true forgo test(and likely also forgo run).