feat: add --build flag to diff command#694
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --build flag to the orchestrion diff command that allows users to build and diff in one step, eliminating the need for separate build and diff commands.
- Adds a new
--buildflag to execute a build with-workbefore generating the diff - Refactors the diff command logic into separate functions for better modularity
- Implements work directory extraction from build output to automatically capture the build workspace
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eliottness
left a comment
eliottness
left a comment
There was a problem hiding this comment.
Optional nit: write at least one test but I know this is hard so if you tested it locally and don't feel like it. Your explicit go is enough.
I'll add some tests |
Add --build flag to orchestrion diff command to build and diff in one step. This provides a quality of life improvement for orchestrion.yaml authors by eliminating the need for separate build and diff commands. Usage: orchestrion diff --build ./... Replaces: orchestrion go build -work ./... && orchestrion diff /work/dir Fixes #692 Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
6f65f55 to
f796dba
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 65.72% 67.19% +1.47%
==========================================
Files 113 113
Lines 7926 8014 +88
==========================================
+ Hits 5209 5385 +176
+ Misses 2192 2107 -85
+ Partials 525 522 -3
🚀 New features to boost your workflow:
|
Add --build flag to orchestrion diff command to build and diff in one step.
This provides a quality of life improvement for orchestrion.yaml authors
by eliminating the need for separate build and diff commands.
Usage: orchestrion diff --build ./...
Replaces: orchestrion go build -work ./... && orchestrion diff /work/dir
Fixes #692
Signed-off-by: Kemal Akkoyun [email protected]