fix(internal/injector): fix processImports for non-imported dst.SelectorExpr#678
Merged
RomainMuller merged 5 commits intoAug 13, 2025
Merged
Conversation
rarguelloF
changed the title
RomainMuller
changed the title
RomainMuller
changed the title
dst.SelectorExpr
RomainMuller
marked this pull request as ready for review
August 13, 2025 09:31
RomainMuller
approved these changes
Aug 13, 2025
Merged
7 tasks
RomainMuller
enabled auto-merge
August 13, 2025 13:55
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 13, 2025
RomainMuller
deleted the
rarguellof/AIDM-706/fix-import-conflict-symbol
branch
August 13, 2025 17:18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 65.72% 68.56% +2.84%
==========================================
Files 113 113
Lines 7926 7925 -1
==========================================
+ Hits 5209 5434 +225
+ Misses 2192 1949 -243
- Partials 525 542 +17
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #674, fixes #670
Process imports before replacing placeholders in template text, so that imports processing is strictly unable to replace symbols from the original AST (as these are hidden behind the placeholders).