feat(injector): add package-filter join point with glob patterns and module filtering#675
Merged
Merged
Conversation
kakkoyun
commented
Aug 8, 2025
RomainMuller
reviewed
Aug 8, 2025
kakkoyun
marked this pull request as draft
August 8, 2025 14:12
hannahkm
reviewed
Aug 8, 2025
kakkoyun
force-pushed
the
kakkoyun/add_package_filter
branch
from
September 1, 2025 11:43
9fa684d to
82c2037
Compare
kakkoyun
marked this pull request as ready for review
September 1, 2025 14:02
kakkoyun
force-pushed
the
kakkoyun/add_package_filter
branch
from
September 11, 2025 11:12
36d164c to
2b1296f
Compare
kakkoyun
marked this pull request as draft
September 11, 2025 15:26
…module filtering Add new "package-filter" join point that supports: - Glob pattern matching with all patterns supported by https://pkg.go.dev/path/filepath#Match - Special "*" pattern for universal matching - Module filtering with "root" for current module only - Specific module targeting (e.g., "github.com/myorg/mymodule") - Relative path matching within modules for precise filtering Signed-off-by: Kemal Akkoyun <[email protected]>
- Simplify packageFilter to use boolean root flag instead of separate module field - Update tests and test data to use new boolean parameter - Add test case for question mark not matching across path separators - Replace shell-based module detection with golang.org/x/tools/go/packages API - Consolidate documentation in public PackageFilter function
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
force-pushed
the
kakkoyun/add_package_filter
branch
from
September 12, 2025 13:47
e37b244 to
8a8d393
Compare
kakkoyun
marked this pull request as ready for review
September 12, 2025 15:26
eliottness
removed their request for review
September 16, 2025 08:54
| - join-point: | ||
| all-of: | ||
| - package-filter: | ||
| root: true |
Contributor
There was a problem hiding this comment.
I'm a little uncertain about what the intention of this primitive is -- like what is the concrete use-case this seeks to address? If that's touching on the main package -- there is already a join point that does this (package: main).
I don't know that Go has a concept of a "root" module, it has a concept of a "module root path", but this is not the same thing...
Member
Author
There was a problem hiding this comment.
I'm a little uncertain about what the intention of this primitive is -- like what is the concrete use-case this seeks to address? If that's touching on the main package -- there is already a join point that does this (package: main).
It's not just the main package. We try to aim the user code and exclude any 3rd party dependencies or standard library.
I don't know that Go has a concept of a "root" module, it has a concept of a "module root path", but this is not the same thing...
I'd be happy to accept better wording if you have any suggestions to define above use case.
kakkoyun
force-pushed
the
kakkoyun/add_package_filter
branch
from
September 19, 2025 09:22
3fdf146 to
9ba33b0
Compare
Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
force-pushed
the
kakkoyun/add_package_filter
branch
from
September 19, 2025 10:25
9ba33b0 to
999e94f
Compare
RomainMuller
approved these changes
Sep 19, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
- Coverage 65.72% 65.70% -0.02%
==========================================
Files 113 114 +1
Lines 7926 8245 +319
==========================================
+ Hits 5209 5417 +208
- Misses 2192 2293 +101
- Partials 525 535 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new "package-filter" join point that supports:
**) support for recursive matching across path segmentsGlobstar Examples:
github.com/myorg/**- matches any package under myorg at any depth**/internal/*- matches internal packages anywhere in dependency treegithub.com/myorg/**/api/**- complex nested pattern matchingSigned-off-by: Kemal Akkoyun [email protected]