chore: enhance typo check workflow#667
Conversation
kakkoyun
left a comment
There was a problem hiding this comment.
Looking good.
Thanks for the contribution.
|
I just noticed that the repository is already using the typos tool, but only for checking documentation. Should I leave spelling workflow as is, or would it be better to add the config file to the existing validate workflow and run it on all files? Alternatively, I can remove the new separate workflow for spelling and stick with checking only the docs as before? |
Nothing to worry about. As a reviewer, I have forgotten we have added it. |
|
Never mind, I've just re-committed these leaving you as the author on record. |
Signed-off-by: atilsensalduz <[email protected]>
f1d6856 to
2a9e306
Compare
|
Really appreciate the merge, @RomainMuller and @kakkoyun I'll set up GPG signing for my future commits |
This PR adds a typo check to CI using the typos GitHub Action. I also created a .typos.toml config file so we can ignore certain words that are either project specific, technical terms, or intentionally spelled that way. Without this config, the action would flag a lot of false positives, so this should make the checks more useful and less noisy.
If you notice any words in the whitelist that actually are typos and should be fixed, feel free to update the config or let me know. For example, I wasn’t sure whether to change “qualifed” to “qualified”, since it appears in a lot of places and might be intentional.
https://github.com/crate-ci/typos