Skip to content

fix: TypeName parser incorrectly rejects leading digits in path segments#646

Merged
RomainMuller merged 3 commits into
mainfrom
romain.marcadier/leading-digit
Jun 13, 2025
Merged

fix: TypeName parser incorrectly rejects leading digits in path segments#646
RomainMuller merged 3 commits into
mainfrom
romain.marcadier/leading-digit

Conversation

@RomainMuller

Copy link
Copy Markdown
Contributor

No description provided.

@RomainMuller
RomainMuller marked this pull request as ready for review June 13, 2025 09:22
@RomainMuller
RomainMuller requested a review from a team as a code owner June 13, 2025 09:22

RomainMuller commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RomainMuller
RomainMuller enabled auto-merge June 13, 2025 09:23
@RomainMuller
RomainMuller added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit dc1c42d Jun 13, 2025
55 of 61 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/leading-digit branch June 13, 2025 14:09
@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (f640dc0) to head (44f5642).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
+ Coverage   68.32%   68.48%   +0.15%     
==========================================
  Files         113      113              
  Lines        7916     7916              
==========================================
+ Hits         5409     5421      +12     
+ Misses       1966     1954      -12     
  Partials      541      541              
Components Coverage Δ
Generators 80.24% <ø> (ø)
Instruments ∅ <ø> (∅)
Go Driver 76.51% <ø> (ø)
Toolexec Driver 70.83% <ø> (ø)
Aspects 74.32% <ø> (ø)
Injector 74.87% <ø> (ø)
Job Server 70.04% <ø> (+1.07%) ⬆️
Other 68.48% <ø> (+0.15%) ⬆️
Files with missing lines Coverage Δ
internal/injector/typed/typename.go 84.14% <ø> (ø)
internal/version/version.go 75.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants