feat(injector): Add ArgumentThatImplements method for argument interface matching#617
Merged
kakkoyun merged 1 commit intoJun 6, 2025
Conversation
This was referenced Apr 16, 2025
Member
Author
This was referenced Apr 16, 2025
kakkoyun
marked this pull request as ready for review
April 16, 2025 08:45
RomainMuller
approved these changes
Apr 23, 2025
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
May 26, 2025 10:52
9c2709c to
be2028f
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
May 26, 2025 10:52
691062e to
1bbd800
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
May 26, 2025 14:17
be2028f to
35ebe90
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
May 26, 2025 14:17
1bbd800 to
985452d
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
May 26, 2025 14:19
35ebe90 to
66e79f8
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
May 26, 2025 14:19
985452d to
24d72c7
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
May 27, 2025 11:40
6e4ae96 to
1c9cd64
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
May 27, 2025 11:40
24d72c7 to
4c0282c
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
May 27, 2025 13:20
4c0282c to
2be634a
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 11:00
1c9cd64 to
d01d615
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
3 times, most recently
from
June 5, 2025 14:25
24682c3 to
d7599d0
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
2 times, most recently
from
June 5, 2025 16:27
d1d3c13 to
b8a2864
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
June 5, 2025 16:27
d7599d0 to
cb660b2
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 17:30
b8a2864 to
ad3e699
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
June 5, 2025 17:30
cb660b2 to
260ef98
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 19:46
ad3e699 to
827efcf
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
June 5, 2025 19:46
260ef98 to
036a718
Compare
Base automatically changed from
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
to
main
June 5, 2025 20:33
…ace matching This commit introduces the `ArgumentThatImplements` method to the function signature, allowing the retrieval of the first argument that implements a specified interface type. The implementation includes a new helper function, `findImplementingField`, which checks for both exact type matches and interface implementations. Additionally, the `ResultThatImplements` method has been refactored to utilize the new helper for consistency. The changes enhance the injector's capability to handle argument interface checks, improving the overall functionality and maintainability of the code. Configuration YAML files and test cases have been added to validate the new functionality across various scenarios, ensuring robust testing of the argument matching feature. Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
force-pushed
the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
from
June 6, 2025 06:12
036a718 to
b1fe0c5
Compare
kakkoyun
enabled auto-merge
June 6, 2025 06:14
kakkoyun
deleted the
04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching
branch
June 6, 2025 07:02
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 66.80% 67.10% +0.29%
==========================================
Files 113 113
Lines 7866 7904 +38
==========================================
+ Hits 5255 5304 +49
- Misses 2068 2082 +14
+ Partials 543 518 -25
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the
ArgumentThatImplementsmethod to the function signature, allowing the retrieval of the first argument that implements a specified interface type. The implementation includes a new helper function,findImplementingField, which checks for both exact type matches and interface implementations.Additionally, the
ResultThatImplementsmethod has been refactored to utilize the new helper for consistency. The changes enhance the injector's capability to handle argument interface checks, improving the overall functionality and maintainability of the code.Configuration YAML files and test cases have been added to validate the new functionality across various scenarios, ensuring robust testing of the argument matching feature.
Signed-off-by: Kemal Akkoyun [email protected]