Conversation
This was referenced Apr 16, 2025
Member
Author
RomainMuller
approved these changes
Apr 22, 2025
kakkoyun
force-pushed
the
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
branch
from
May 26, 2025 10:52
c56bf17 to
6c4905d
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
May 26, 2025 10:52
9c2709c to
be2028f
Compare
kakkoyun
force-pushed
the
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
branch
from
May 26, 2025 14:16
6c4905d to
62d099c
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
2 times, most recently
from
May 26, 2025 14:19
35ebe90 to
66e79f8
Compare
kakkoyun
force-pushed
the
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
branch
from
May 26, 2025 14:19
62d099c to
f5ea563
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
May 27, 2025 11:40
6e4ae96 to
1c9cd64
Compare
RomainMuller
approved these changes
Jun 3, 2025
kakkoyun
changed the base branch from
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
to
graphite-base/616
June 5, 2025 10:56
github-actions
Bot
added
the
conventional-commit/chore
kakkoyun
force-pushed
the
graphite-base/616
branch
from
June 5, 2025 11:00
d2cdd1b to
bbe2ed1
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 11:00
1c9cd64 to
d01d615
Compare
kakkoyun
changed the base branch from
graphite-base/616
to
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
June 5, 2025 11:00
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 14:25
d053f83 to
d1d3c13
Compare
kakkoyun
force-pushed
the
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
branch
from
June 5, 2025 14:25
bbe2ed1 to
d575c0b
Compare
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 16:27
d1d3c13 to
b8a2864
Compare
kakkoyun
force-pushed
the
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
branch
from
June 5, 2025 16:27
d575c0b to
a59cbdb
Compare
Base automatically changed from
04-15-refactor_injector_refactor_typename_handling_and_migrate_to_typed_package
to
main
June 5, 2025 17:21
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 17:30
b8a2864 to
ad3e699
Compare
kakkoyun
enabled auto-merge
June 5, 2025 17:31
…roved clarity and error handling This update refactors the `ResolveInterfaceTypeByName` function to enhance its structure and error reporting. The function now separates the logic for handling built-in types and package-qualified types, improving readability. A new helper function, `validateTypeNameIsInterface`, has been introduced to encapsulate the validation of interface types, ensuring consistent error messages and reducing code duplication. Additionally, specific error messages have been added for import failures and type lookups, providing clearer context for users. Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
force-pushed
the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
from
June 5, 2025 19:46
ad3e699 to
827efcf
Compare
kakkoyun
disabled auto-merge
June 5, 2025 19:47
kakkoyun
enabled auto-merge
June 5, 2025 19:47
kakkoyun
deleted the
04-15-feat_injector_typed_refactor_resolveinterfacetypebyname_for_improved_clarity_and_error_handling
branch
June 5, 2025 20:33
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
- Coverage 68.49% 66.80% -1.69%
==========================================
Files 113 113
Lines 7868 7866 -2
==========================================
- Hits 5389 5255 -134
- Misses 1938 2068 +130
- Partials 541 543 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update refactors the
ResolveInterfaceTypeByNamefunction to enhance its structure and error reporting. The function now separates the logic for handling built-in types and package-qualified types, improving readability. A new helper function,validateTypeNameIsInterface, has been introduced to encapsulate the validation of interface types, ensuring consistent error messages and reducing code duplication.Additionally, specific error messages have been added for import failures and type lookups, providing clearer context for users.
Signed-off-by: Kemal Akkoyun [email protected]