Enable RUM feature flag tracking by default if RUM is available#176
Merged
Enable RUM feature flag tracking by default if RUM is available#176
Conversation
petzel
requested review from
dd-oleksii,
greghuels,
leoromanovsky and
typotter
leoromanovsky
approved these changes
Feb 9, 2026
Comment on lines
-59
to
+60
| // Should have 2 hooks: flag evaluation tracking (default true) + exposure logging (default true) | ||
| expect(providerWithDefaults.hooks).toHaveLength(2) | ||
| // Should have 3 hooks: flag evaluation tracking (default true) + exposure logging (default true) + auto RUM tracking | ||
| expect(providerWithDefaults.hooks).toHaveLength(3) |
Collaborator
There was a problem hiding this comment.
sorry for this; I haven't figure out a "good way" to test it otherwise. Did you find it valuable or a chore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if a user wants to enable RUM Feature Flag Tracking, they need to set deprecated configuration fields. If these fields happen to be set, the variant values are used, rather than the variant keys, which is not desirable primarily since JSON flags a) lead to a poor UX and b) use significantly more storage than keys in most cases.
Changes
This PR adds a new hook which automatically adds feature flag information to RUM events by calling
rum.addFeatureFlagEvaluationif RUM is available. Users can optionally disable this tracking by settingenableRumFeatureFlagTracking: falsewhen initializing.For some reason, the variant keys being returned by the precomputed endpoint do not contain exactly what the user entered as the variant key - they include a suffix (such as
-0). Since this comes from the backend/another repo, I will update this in a separate PR.Test instructions
Checklist