fix resource renaming not enabled if appsec enabled via env#401
Merged
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 60b53ae | Docs | Datadog PR Page | Give us feedback! |
xlamorlette-datadog
approved these changes
Jun 15, 2026
|
|
||
| def test_appsec_env_enables_fallback_mode_by_default(self): | ||
| """Verify that DD_APPSEC_ENABLED=true enables endpoint renaming by default.""" | ||
| if self.waf_disabled: |
Contributor
There was a problem hiding this comment.
opt: Use a decorator to factorize this:
In case.py:
import functools
def skip_if_waf_disabled(func):
@functools.wraps(func)
def wrapper(self, *args, **kwargs):
if self.waf_disabled:
self.skipTest("WAF is disabled - appsec test requires WAF support")
return func(self, *args, **kwargs)
return wrapper
Then:
@case.skip_if_waf_disabled
def test_appsec_enables_fallback_mode_by_default(self):
@case.skip_if_waf_disabled
def test_appsec_env_enables_fallback_mode_by_default(self):
|
|
||
| return status, nginx_spans[0] | ||
|
|
||
| def send_request_and_get_span_with_env(self, url, config_name, extra_env): |
Contributor
There was a problem hiding this comment.
nit: please add type hints for function parameters (and return values)
| "log_lines": log_lines, | ||
| }) | ||
|
|
||
| return 200, nginx_spans[0] |
Contributor
There was a problem hiding this comment.
nit: rather return status (even if always 200 because of the assert line 54)?
|
|
||
| log_lines = self.orch.sync_service('agent') | ||
| spans = formats.parse_spans(log_lines) | ||
| nginx_spans = [ |
Contributor
There was a problem hiding this comment.
nit: should we have a similar spans filtering in send_request_and_get_span() above?
cataphract
force-pushed
the
glopes/fix-resource-renaming
branch
from
June 15, 2026 13:42
90b5d98 to
57feaa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resource renaming is not explicitly enabled or disabled, it should get enabled if appsec is explicitly enabled (not via remote config). However, we were only checking for the enablement via nginx config file, not the env var. Fix that