Release v1.16.1#366
Conversation
xlamorlette-datadog
changed the title
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d83a752 | Docs | Datadog PR Page | Give us feedback! |
@xlamorlette-datadog if this is leading to failures, we can also consider separating this into a separate PR |
This comes with the removal of the support of Nginx 1.24.0. I think I could get a fix within a reasonable timeframe by upgrading the used |
@xlamorlette-datadog yep I understand that this came with the removal of Nginx 1.24.0. If it takes more than an hour to resolve, I suggest reverting the change and we can tackle separately |
… fix CI gitretriever error with bearer-token auth
…no longer pulls it in transitively)
e54f9a8 to
d83a752
Compare
Relative submodule URLs (`../foo.git`) get resolved against the parent repo's URL — which on DDbuild is the gitretriever URL the runner uses to fetch the main repo. The existing `url.https://[email protected]/DataDog/.insteadOf` rule in .gitlab-ci.yml only rewrites `https://github.com/DataDog/`, so the gitretriever-resolved submodule URLs slipped past it and hit `fatal: could not read Username` in get_sources (pipeline #420). Switching the submodule URLs to absolute github.com URLs makes the existing insteadOf rule actually match, so submodule clones go through the authenticated gitlab.ddbuild.io mirror. Same fix landed in DataDog/nginx-datadog#366 (commit fc330c9).
3 participants
Prepare release
v1.16.1, with the following changes:dd-trace-cppto v2.1.0.1.24.0).