build(test): restrict gdb-15 install to amd64 architecture#114
Merged
Conversation
dmehala
force-pushed
the
dmehala/fix-it-docker-build
branch
from
September 19, 2024 09:35
bb2ae08 to
2b2bf27
Compare
dmehala
commented
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 77.22% 77.22%
=======================================
Files 36 36
Lines 4000 4000
Branches 671 671
=======================================
Hits 3089 3089
Misses 875 875
Partials 36 36 |
Contributor
|
It seems that we don't want to do anything on non amd64 system, do you know why ? |
Contributor
Author
|
@dubloom gdb is installed for all architecture, but gdb-15 will not be installed for ubuntu on arm64 architecture for the following reasons:
|
pablomartinezbernardo
approved these changes
Sep 19, 2024
PR #71 updates gdb to a newer version that supports reading DWARF debugging format. However, it incorrectly attempts to install the x86_64 version regardless of the system's architecture, causing errors on non-x86_64 platforms. This fix temporarily ensures that the updated gdb is only installed on x86_64 (amd64) systems.
dmehala
force-pushed
the
dmehala/fix-it-docker-build
branch
from
September 19, 2024 13:50
ef4c733 to
8fa19d4
Compare
cataphract
pushed a commit
that referenced
this pull request
Oct 30, 2024
PR #71 updates gdb to a newer version that supports reading DWARF debugging format. However, it incorrectly attempts to install the x86_64 version regardless of the system's architecture, causing errors on non-x86_64 platforms. This fix temporarily ensures that the updated gdb is only installed on x86_64 (amd64) systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #71 updates gdb to a newer version that supports reading DWARF debugging format. However, it incorrectly attempts to install the x86_64 version regardless of the system's architecture, causing errors on non-x86_64 platforms.
This fix temporarily ensures that the updated gdb is only installed on x86_64 (amd64) systems.
Note to reviewers
This is blocking the new release.