chore: fix dd-trace-cpp API usage#106
Merged
Merged
Conversation
dmehala
force-pushed
the
dmehala/next-dd-trace-cpp
branch
from
August 20, 2024 16:18
1f30b15 to
c4ff758
Compare
dmehala
changed the title
dd-trace-cpp API usagedd-trace-cpp API usage
dmehala
changed the title
dd-trace-cpp API usagedd-trace-cpp API usage
dmehala
marked this pull request as ready for review
August 20, 2024 16:22
dmehala
changed the title
dd-trace-cpp API usagedd-trace-cpp API usage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 66.95% 67.08% +0.13%
==========================================
Files 35 35
Lines 3465 3476 +11
Branches 606 606
==========================================
+ Hits 2320 2332 +12
Misses 826 826
+ Partials 319 318 -1
|
pablomartinezbernardo
approved these changes
Aug 21, 2024
pablomartinezbernardo
left a comment
pablomartinezbernardo
left a comment
Contributor
There was a problem hiding this comment.
I'm failing to see why we need to skip that test, what has changed that broke the behavior in the test?
Otherwise LGTM
dmehala
force-pushed
the
dmehala/next-dd-trace-cpp
branch
from
August 27, 2024 12:21
c4ff758 to
74444c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
dd-trace-cpp@d354e96.rapidjsoninstead ofnlohmann::json.Temporarily disabledtest_configuration.py:test_in_http.