Skip to content

fix warnings when building for wasm32#499

Merged
cataphract merged 1 commit into
masterfrom
glopes/fix-warnings-wasm32
Jun 29, 2026
Merged

fix warnings when building for wasm32#499
cataphract merged 1 commit into
masterfrom
glopes/fix-warnings-wasm32

Conversation

@cataphract

@cataphract cataphract commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cataphract
cataphract requested a review from a team as a code owner June 28, 2026 18:01
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 28, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 62.50%
• Overall Coverage: 84.78% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8e7ded9 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.77%. Comparing base (7a17b8d) to head (ada1ae5).

Files with missing lines Patch % Lines
src/processor/extract_schema.cpp 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   84.78%   84.77%   -0.01%     
==========================================
  Files         191      191              
  Lines        9341     9342       +1     
  Branches     4184     4184              
==========================================
  Hits         7920     7920              
- Misses        529      530       +1     
  Partials      892      892
Flag Coverage Δ
waf_test 84.77% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 2020576 2020032 -0.02%
darwin-universal::libddwaf.dylib 4248800 4231872 -0.39%
darwin-x86_64::libddwaf.dylib 2208040 2207496 -0.02%
linux-aarch64::libddwaf.so 2388576 2385792 -0.11%
linux-armv7::libddwaf.so 2056400 2055504 -0.04%
linux-i386::libddwaf.so 2312900 2306052 -0.29%
linux-x86_64::libddwaf.so 2581376 2578080 -0.12%
windows-arm64::ddwaf.dll 6731264 6718976 -0.18%
windows-win32::ddwaf.dll 3330560 3322368 -0.24%
windows-x64::ddwaf.dll 4061184 4062208 0.02%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 92531240 92525600 0.00%
darwin-arm64::libddwaf.a.stripped 4715920 4716264 0.00%
darwin-universal::libddwaf.a 186577856 186570288 0.00%
darwin-universal::libddwaf.a.stripped 10041896 10042896 0.00%
darwin-x86_64::libddwaf.a 94046568 94044640 0.00%
darwin-x86_64::libddwaf.a.stripped 5325928 5326584 0.01%
linux-aarch64::libddwaf.a 75455020 75467166 0.01%
linux-aarch64::libddwaf.a.stripped 12184592 12182450 -0.01%
linux-armv7::libddwaf.a 66674258 66686506 0.01%
linux-armv7::libddwaf.a.stripped 11189582 11189786 0.00%
linux-i386::libddwaf.a 64858564 64868358 0.01%
linux-i386::libddwaf.a.stripped 9676948 9676154 0.00%
linux-x86_64::libddwaf.a 75942542 75951178 0.01%
linux-x86_64::libddwaf.a.stripped 11985466 11985126 0.00%
windows-arm64::ddwaf.lib 16902 16902 0.00%
windows-arm64::ddwaf_static.lib 135254130 134608756 -0.47%
windows-win32::ddwaf.lib 17228 17228 0.00%
windows-win32::ddwaf_static.lib 47779818 47460218 -0.66%
windows-x64::ddwaf.lib 16902 16902 0.00%
windows-x64::ddwaf_static.lib 55616486 55237794 -0.68%

@cataphract
cataphract force-pushed the glopes/fix-warnings-wasm32 branch from 6dc4659 to ada1ae5 Compare June 28, 2026 18:27
@cataphract
cataphract enabled auto-merge (squash) June 29, 2026 12:53
@cataphract
cataphract disabled auto-merge June 29, 2026 12:53
@cataphract
cataphract enabled auto-merge (squash) June 29, 2026 12:55
@cataphract
cataphract force-pushed the glopes/fix-warnings-wasm32 branch from ada1ae5 to 8e7ded9 Compare June 29, 2026 12:55
@cataphract
cataphract merged commit 4e91ad0 into master Jun 29, 2026
55 of 56 checks passed
@cataphract
cataphract deleted the glopes/fix-warnings-wasm32 branch June 29, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estringana estringana estringana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cataphract @codecov-commenter @estringana