Fix bad has_from_chars concept#497
Merged
Merged
Conversation
Anilm3
approved these changes
Jun 12, 2026
cataphract
enabled auto-merge (squash)
June 12, 2026 15:30
|
🎯 Code Coverage (details) 🔗 Commit SHA: 80dbf16 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 191 191
Lines 9341 9341
Branches 4184 4184
=======================================
Hits 7920 7920
Misses 529 529
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dynamic Artifact Size Comparison 📦
Static Artifact Size Comparison 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_chars takes the value as a (non-const) reference, so the rvalue reference produced by declval doesn't bind.