Skip to content

Report input attribute addresses on ddwaf_known_addresses#485

Merged
Anilm3 merged 1 commit into
masterfrom
anilm3/known-address-1.30.1-patch
Dec 12, 2025
Merged

Report input attribute addresses on ddwaf_known_addresses#485
Anilm3 merged 1 commit into
masterfrom
anilm3/known-address-1.30.1-patch

Conversation

@Anilm3

@Anilm3 Anilm3 commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator

This PR adds the patch introduced in #484 to the master branch.

@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage December 12, 2025 10:28 — with GitHub Actions Inactive
@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage December 12, 2025 10:54 — with GitHub Actions Inactive
@pr-commenter

pr-commenter Bot commented Dec 12, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-12-12 10:56:34

Comparing candidate commit 552b8bb in PR branch anilm3/known-address-1.30.1-patch with baseline commit 5d64fa7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@github-actions

github-actions Bot commented Dec 12, 2025

Copy link
Copy Markdown

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 2027984 2004032 -1.18%
darwin-universal::libddwaf.dylib 4256208 4215872 -0.94%
darwin-x86_64::libddwaf.dylib 2213736 2195712 -0.81%
linux-aarch64::libddwaf.so 2463376 2376080 -3.54%
linux-armv7::libddwaf.so 2148940 2041304 -5.00%
linux-i386::libddwaf.so 2392980 2297852 -3.97%
linux-x86_64::libddwaf.so 2660256 2569392 -3.41%
windows-arm64::ddwaf.dll 4790272 4783104 -0.14%
windows-win32::ddwaf.dll 3368960 3320320 -1.44%
windows-x64::ddwaf.dll 4102656 4051456 -1.24%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 91537528 92267968 0.79%
darwin-arm64::libddwaf.a.stripped 4582760 4698440 2.52%
darwin-universal::libddwaf.a 184432872 186057384 0.88%
darwin-universal::libddwaf.a.stripped 9776864 10016984 2.45%
darwin-x86_64::libddwaf.a 92895296 93789368 0.96%
darwin-x86_64::libddwaf.a.stripped 5194056 5318496 2.39%
linux-aarch64::libddwaf.a 73173714 75430246 3.08%
linux-aarch64::libddwaf.a.stripped 11851494 12167602 2.66%
linux-armv7::libddwaf.a 64732098 66623488 2.92%
linux-armv7::libddwaf.a.stripped 10852278 11179392 3.01%
linux-i386::libddwaf.a 62858558 64820678 3.12%
linux-i386::libddwaf.a.stripped 9379838 9685194 3.25%
linux-x86_64::libddwaf.a 73660850 75929280 3.07%
linux-x86_64::libddwaf.a.stripped 11670798 11979604 2.64%
windows-arm64::ddwaf.lib 11698 16410 40.27%
windows-arm64::ddwaf_static.lib 57964164 55850578 -3.64%
windows-win32::ddwaf.lib 11922 16726 40.29%
windows-win32::ddwaf_static.lib 49576448 47763686 -3.65%
windows-x64::ddwaf.lib 11698 16410 40.27%
windows-x64::ddwaf_static.lib 57456080 55587718 -3.25%

@Anilm3
Anilm3 merged commit 3a06266 into master Dec 12, 2025
80 of 83 checks passed
@Anilm3
Anilm3 deleted the anilm3/known-address-1.30.1-patch branch December 12, 2025 11:08
Anilm3 added a commit that referenced this pull request Dec 12, 2025
@Anilm3
Report input attribute addresses on ddwaf_known_addresses (#485)
f7341a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estringana estringana estringana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anilm3 @estringana