Skip to content

Report input attribute addresses on ddwaf_known_addresses, increase macos target and increase version to v1.30.1#484

Merged
Anilm3 merged 3 commits into
libddwaf-1.30.1from
anilm3/input-attribute-address-known-addresses
Dec 11, 2025
Merged

Report input attribute addresses on ddwaf_known_addresses, increase macos target and increase version to v1.30.1#484
Anilm3 merged 3 commits into
libddwaf-1.30.1from
anilm3/input-attribute-address-known-addresses

Conversation

@Anilm3

@Anilm3 Anilm3 commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Report input attribute addresses on ddwaf_known_addresses
  • Increase MacOS target to 14.2.1 (due to macos-13 runner deprecation)
  • Release v1.30.1

@Anilm3
Anilm3 requested a review from a team as a code owner December 9, 2025 13:19
@codecov-commenter

codecov-commenter commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.27%. Comparing base (00e895f) to head (974d51e).

Files with missing lines Patch % Lines
src/rule.hpp 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           libddwaf-1.30.1     #484      +/-   ##
===================================================
- Coverage            85.28%   85.27%   -0.02%     
===================================================
  Files                  186      186              
  Lines                 8959     8963       +4     
  Branches              4131     4135       +4     
===================================================
+ Hits                  7641     7643       +2     
  Misses                 501      501              
- Partials               817      819       +2
Flag Coverage Δ
waf_test 85.27% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter

pr-commenter Bot commented Dec 9, 2025

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-12-09 13:42:09

Comparing candidate commit ef57a2c in PR branch anilm3/input-attribute-address-known-addresses with baseline commit 00e895f in branch libddwaf-1.30.1.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Dec 9, 2025

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-12-09 13:42:17

Comparing candidate commit ef57a2c in PR branch anilm3/input-attribute-address-known-addresses with baseline commit 00e895f in branch libddwaf-1.30.1.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Dec 9, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-12-09 13:56:21

Comparing candidate commit ef57a2c in PR branch anilm3/input-attribute-address-known-addresses with baseline commit 00e895f in branch libddwaf-1.30.1.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@github-actions

github-actions Bot commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 90006808 91537528 0.01%
darwin-arm64::libddwaf.a.stripped 4579664 4582760 0.00%
darwin-arm64::libddwaf.dylib 1963024 2027984 0.03%
darwin-universal::libddwaf.a 181421048 184432872 0.01%
darwin-universal::libddwaf.a.stripped 9765560 9776864 0.00%
darwin-universal::libddwaf.dylib 4142096 4256208 0.02%
darwin-x86_64::libddwaf.a 91414192 92895296 0.01%
darwin-x86_64::libddwaf.a.stripped 5185848 5194056 0.00%
darwin-x86_64::libddwaf.dylib 2150896 2213736 0.02%
linux-aarch64::libddwaf.a 73159398 73173714 0.00%
linux-aarch64::libddwaf.a.stripped 11852314 11851494 0.00%
linux-aarch64::libddwaf.so 2463264 2463376 0.00%
linux-armv7::libddwaf.a 64719602 64732098 0.00%
linux-armv7::libddwaf.a.stripped 10852830 10852278 0.00%
linux-armv7::libddwaf.so 2148796 2148940 0.00%
linux-i386::libddwaf.a 62843294 62858558 0.00%
linux-i386::libddwaf.a.stripped 9380114 9379838 0.00%
linux-i386::libddwaf.so 2392820 2392980 0.00%
linux-x86_64::libddwaf.a 73646022 73660850 0.00%
linux-x86_64::libddwaf.a.stripped 11671354 11670798 0.00%
linux-x86_64::libddwaf.so 2660096 2660256 0.00%
windows-arm64::ddwaf.dll 4788736 4790272 0.00%
windows-arm64::ddwaf.lib 11698 11698 0.00%
windows-arm64::ddwaf_static.lib 57913956 57964164 0.00%
windows-win32::ddwaf.dll 3368448 3368960 0.00%
windows-win32::ddwaf.lib 11922 11922 0.00%
windows-win32::ddwaf_static.lib 49534552 49576448 0.00%
windows-x64::ddwaf.dll 4101632 4102656 0.00%
windows-x64::ddwaf.lib 11698 11698 0.00%
windows-x64::ddwaf_static.lib 57410292 57456080 0.00%
windows-x86_64::libddwaf.a 6539872 6538190 0.00%
windows-x86_64::libddwaf.dll 18890291 18888218 0.00%
windows-x86_64::libddwaf.dll.a 31948 31948 0.00%

@Anilm3 Anilm3 changed the title Report input attribute addresses on ddwaf_known_addresses Report input attribute addresses on ddwaf_known_addresses, increase macos target and increase version to v1.30.1 Dec 10, 2025
@Anilm3
Anilm3 force-pushed the anilm3/input-attribute-address-known-addresses branch from 4e9ff88 to 974d51e Compare December 10, 2025 14:11
@Anilm3
Anilm3 merged commit da7fd66 into libddwaf-1.30.1 Dec 11, 2025
56 checks passed
@Anilm3
Anilm3 deleted the anilm3/input-attribute-address-known-addresses branch December 11, 2025 12:52
@Anilm3 Anilm3 mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataphract cataphract cataphract approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anilm3 @codecov-commenter @cataphract