Skip to content

Add option to build on valgrind to avoid RE2 UB noise#480

Merged
Anilm3 merged 3 commits into
masterfrom
anilm3/add-on-valgrind-build-opt
Nov 6, 2025
Merged

Add option to build on valgrind to avoid RE2 UB noise#480
Anilm3 merged 3 commits into
masterfrom
anilm3/add-on-valgrind-build-opt

Conversation

@Anilm3

@Anilm3 Anilm3 commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@Anilm3
Anilm3 requested a review from a team as a code owner November 5, 2025 19:10
@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 19:20 — with GitHub Actions Inactive
@codecov-commenter

codecov-commenter commented Nov 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.41%. Comparing base (d9dd3eb) to head (b63aaf8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         189      189           
  Lines        9279     9279           
  Branches     4229     4229           
=======================================
  Hits         7833     7833           
  Misses        529      529           
  Partials      917      917           
Flag Coverage Δ
waf_test 84.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 5, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 94.00% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b63aaf8 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 1963024 2165120 10.29%
darwin-universal::libddwaf.dylib 4142096 4540800 9.62%
darwin-x86_64::libddwaf.dylib 2150896 2360088 9.72%
linux-aarch64::libddwaf.so 2463264 2549432 3.49%
linux-armv7::libddwaf.so 2148796 2221912 3.40%
linux-i386::libddwaf.so 2392820 2488156 3.98%
linux-x86_64::libddwaf.so 2660096 2760512 3.77%
windows-arm64::ddwaf.dll 4788736 4966400 3.71%
windows-win32::ddwaf.dll 3368448 3493888 3.72%
windows-x64::ddwaf.dll 4101632 4224512 2.99%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 90006808 127953448 42.15%
darwin-arm64::libddwaf.a.stripped 4579664 9669688 111.14%
darwin-universal::libddwaf.a 181421048 260318768 43.48%
darwin-universal::libddwaf.a.stripped 9765560 20552736 110.46%
darwin-x86_64::libddwaf.a 91414192 132365272 44.79%
darwin-x86_64::libddwaf.a.stripped 5185848 10883000 109.85%
linux-aarch64::libddwaf.a 73159398 105508126 44.21%
linux-aarch64::libddwaf.a.stripped 11852314 20663194 74.33%
linux-armv7::libddwaf.a 64719602 93045172 43.76%
linux-armv7::libddwaf.a.stripped 10852830 19268836 77.54%
linux-i386::libddwaf.a 62843294 91706662 45.92%
linux-i386::libddwaf.a.stripped 9380114 17683014 88.51%
linux-x86_64::libddwaf.a 73646022 106740074 44.93%
linux-x86_64::libddwaf.a.stripped 11671354 20471598 75.40%
windows-arm64::ddwaf.lib 11698 16410 40.27%
windows-arm64::ddwaf_static.lib 57913956 94805416 63.70%
windows-win32::ddwaf.lib 11922 16726 40.29%
windows-win32::ddwaf_static.lib 49534552 73585690 48.55%
windows-x64::ddwaf.lib 11698 16410 40.27%
windows-x64::ddwaf_static.lib 57410292 85850488 49.53%

@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 20:01 — with GitHub Actions Inactive
@pr-commenter

pr-commenter Bot commented Nov 5, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-11-05 20:28:53

Comparing candidate commit b63aaf8 in PR branch anilm3/add-on-valgrind-build-opt with baseline commit d9dd3eb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.


if [[ $baseline_size -gt 0 ]]; then
diff=$(echo "scale=2; ($candidate_size-$baseline_size)/($baseline_size + 1)" | bc -l | awk '{printf "%.2f\n", $0}')
diff=$(echo "scale=2; 100*($candidate_size-$baseline_size)/($baseline_size + 1)" | bc -l | awk '{printf "%.2f\n", $0}')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this 100?

@Anilm3
Anilm3 merged commit 1d9c11e into master Nov 6, 2025
54 checks passed
@Anilm3
Anilm3 deleted the anilm3/add-on-valgrind-build-opt branch November 6, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants