Skip to content

Upgrade fmt dependency and use as header-only#478

Merged
Anilm3 merged 11 commits into
masterfrom
anilm3/upgrade-fmt-dependecy
Nov 5, 2025
Merged

Upgrade fmt dependency and use as header-only#478
Anilm3 merged 11 commits into
masterfrom
anilm3/upgrade-fmt-dependecy

Conversation

@Anilm3

@Anilm3 Anilm3 commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@Anilm3
Anilm3 requested a review from a team as a code owner November 5, 2025 13:21
@Anilm3
Anilm3 force-pushed the anilm3/upgrade-fmt-dependecy branch from 2f20af2 to 0eeea42 Compare November 5, 2025 13:22
@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 13:31 — with GitHub Actions Inactive
@codecov-commenter

codecov-commenter commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.41%. Comparing base (fe729ab) to head (531b473).

Files with missing lines Patch % Lines
src/tokenizer/sql_base.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   85.05%   84.41%   -0.64%     
==========================================
  Files         189      189              
  Lines        9279     9279              
  Branches     4225     4229       +4     
==========================================
- Hits         7892     7833      -59     
  Misses        529      529              
- Partials      858      917      +59
Flag Coverage Δ
waf_test 84.41% <66.66%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official

datadog-official Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 66.67%
• Total Coverage: 94.00% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 531b473 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 13:46 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 1963024 2165120 0.10%
darwin-universal::libddwaf.dylib 4142096 4540800 0.09%
darwin-x86_64::libddwaf.dylib 2150896 2360088 0.09%
linux-aarch64::libddwaf.so 2463264 2549432 0.03%
linux-armv7::libddwaf.so 2148796 2221912 0.03%
linux-i386::libddwaf.so 2392820 2488156 0.03%
linux-x86_64::libddwaf.so 2660096 2760512 0.03%
windows-arm64::ddwaf.dll 4788736 4966400 0.03%
windows-win32::ddwaf.dll 3368448 3493888 0.03%
windows-x64::ddwaf.dll 4101632 4224512 0.02%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 90006808 127953448 0.42%
darwin-arm64::libddwaf.a.stripped 4579664 9669688 1.11%
darwin-universal::libddwaf.a 181421048 260318768 0.43%
darwin-universal::libddwaf.a.stripped 9765560 20552736 1.10%
darwin-x86_64::libddwaf.a 91414192 132365272 0.44%
darwin-x86_64::libddwaf.a.stripped 5185848 10883000 1.09%
linux-aarch64::libddwaf.a 73159398 105508126 0.44%
linux-aarch64::libddwaf.a.stripped 11852314 20663194 0.74%
linux-armv7::libddwaf.a 64719602 93045172 0.43%
linux-armv7::libddwaf.a.stripped 10852830 19268836 0.77%
linux-i386::libddwaf.a 62843294 91706662 0.45%
linux-i386::libddwaf.a.stripped 9380114 17683014 0.88%
linux-x86_64::libddwaf.a 73646022 106740074 0.44%
linux-x86_64::libddwaf.a.stripped 11671354 20471598 0.75%
windows-arm64::ddwaf.lib 11698 16410 0.40%
windows-arm64::ddwaf_static.lib 57913956 94805416 0.63%
windows-win32::ddwaf.lib 11922 16726 0.40%
windows-win32::ddwaf_static.lib 49534552 73585690 0.48%
windows-x64::ddwaf.lib 11698 16410 0.40%
windows-x64::ddwaf_static.lib 57410292 85850488 0.49%

@pr-commenter

pr-commenter Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-11-05 16:21:48

Comparing candidate commit 531b473 in PR branch anilm3/upgrade-fmt-dependecy with baseline commit fe729ab in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 14:26 — with GitHub Actions Inactive
Base automatically changed from anilm3/increase-macos-target-14.2 to master November 5, 2025 14:29
@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 14:57 — with GitHub Actions Inactive
@Anilm3
Anilm3 enabled auto-merge (squash) November 5, 2025 15:18
@Anilm3
Anilm3 disabled auto-merge November 5, 2025 15:22
@Anilm3
Anilm3 force-pushed the anilm3/upgrade-fmt-dependecy branch from 7d9f7ae to 531b473 Compare November 5, 2025 15:45
@Anilm3
Anilm3 enabled auto-merge (squash) November 5, 2025 15:47
@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 15:56 — with GitHub Actions Inactive
@Anilm3
Anilm3 disabled auto-merge November 5, 2025 16:22
@Anilm3
Anilm3 merged commit d9dd3eb into master Nov 5, 2025
54 checks passed
@Anilm3
Anilm3 deleted the anilm3/upgrade-fmt-dependecy branch November 5, 2025 16:22
cataphract pushed a commit that referenced this pull request May 28, 2026
@Anilm3 @cataphract
Upgrade fmt dependency and use as header-only (#478)
3e1cb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataphract cataphract cataphract approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anilm3 @codecov-commenter @cataphract