Skip to content

Increase MacOS target to 14.2.1#477

Merged
Anilm3 merged 2 commits into
masterfrom
anilm3/increase-macos-target-14.2
Nov 5, 2025
Merged

Increase MacOS target to 14.2.1#477
Anilm3 merged 2 commits into
masterfrom
anilm3/increase-macos-target-14.2

Conversation

@Anilm3

@Anilm3 Anilm3 commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

Due to the impending deprecation of macos-13 runners, the OSX target has to be increased.

Any 13.x target will require significant backporting of std::memory_resource since it's neither available in std nor std::experimental in this version of the SDK. Additionally although not entirely confirmed, 13.x targets don't seem to be supported on mac-14 and above runners.

As a consequence, the chosen target is 14.2.1, which was released in December 2023, while the current target (12.7) was released on September 2023.

@Anilm3
Anilm3 requested a review from a team as a code owner November 4, 2025 18:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CMakeLists.txt
Comment thread .github/workflows/build.yml
@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 4, 2025 18:37 — with GitHub Actions Inactive
@codecov-commenter

codecov-commenter commented Nov 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.05%. Comparing base (68e4725) to head (c966bed).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         189      189           
  Lines        9279     9279           
  Branches     4225     4225           
=======================================
  Hits         7892     7892           
  Misses        529      529           
  Partials      858      858           
Flag Coverage Δ
waf_test 85.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official

datadog-official Bot commented Nov 4, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 94.00% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c966bed | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 90006808 97047848 0.07%
darwin-arm64::libddwaf.a.stripped 4579664 4878608 0.06%
darwin-arm64::libddwaf.dylib 1963024 2088304 0.06%
darwin-universal::libddwaf.a 181421048 195841376 0.07%
darwin-universal::libddwaf.a.stripped 9765560 10398424 0.06%
darwin-universal::libddwaf.dylib 4142096 4382064 0.05%
darwin-x86_64::libddwaf.a 91414192 98793480 0.08%
darwin-x86_64::libddwaf.a.stripped 5185848 5519768 0.06%
darwin-x86_64::libddwaf.dylib 2150896 2283240 0.06%
linux-aarch64::libddwaf.a 73159398 78322240 0.07%
linux-aarch64::libddwaf.a.stripped 11852314 12512044 0.05%
linux-aarch64::libddwaf.so 2463264 2520768 0.02%
linux-armv7::libddwaf.a 64719602 69315316 0.07%
linux-armv7::libddwaf.a.stripped 10852830 11478856 0.05%
linux-armv7::libddwaf.so 2148796 2185128 0.01%
linux-i386::libddwaf.a 62843294 67376762 0.07%
linux-i386::libddwaf.a.stripped 9380114 9929026 0.05%
linux-i386::libddwaf.so 2392820 2448700 0.02%
linux-x86_64::libddwaf.a 73646022 78811470 0.07%
linux-x86_64::libddwaf.a.stripped 11671354 12310634 0.05%
linux-x86_64::libddwaf.so 2660096 2723328 0.02%
windows-arm64::ddwaf.dll 4788736 4944896 0.03%
windows-arm64::ddwaf.lib 11698 16410 0.40%
windows-arm64::ddwaf_static.lib 57913956 61079060 0.05%
windows-win32::ddwaf.dll 3368448 3484672 0.03%
windows-win32::ddwaf.lib 11922 16726 0.40%
windows-win32::ddwaf_static.lib 49534552 52551612 0.06%
windows-x64::ddwaf.dll 4101632 4212224 0.02%
windows-x64::ddwaf.lib 11698 16410 0.40%
windows-x64::ddwaf_static.lib 57410292 60798668 0.05%

@Anilm3
Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 13:26 — with GitHub Actions Inactive
@pr-commenter

pr-commenter Bot commented Nov 5, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-11-05 13:56:30

Comparing candidate commit c966bed in PR branch anilm3/increase-macos-target-14.2 with baseline commit 68e4725 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 merged commit fe729ab into master Nov 5, 2025
54 checks passed
@Anilm3
Anilm3 deleted the anilm3/increase-macos-target-14.2 branch November 5, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants