Skip to content

Incremental processor overrides#461

Merged
Anilm3 merged 3 commits into
masterfrom
anilm3/incremental-processor-overrides
Sep 29, 2025
Merged

Incremental processor overrides#461
Anilm3 merged 3 commits into
masterfrom
anilm3/incremental-processor-overrides

Conversation

@Anilm3

@Anilm3 Anilm3 commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator

This PR updates processor overrides to the new definition which adds or removes scanners to a given processor rather than fully replacing the whole set. The existing implementation is not currently in use, therefore there is no risk for existing users. More information can be found in RFC-1071.

An example processor override, adding and removing scanners, can be seen below:

{
  "processor_overrides": [
    {
      "target": [{ "id": "extract-headers" }, { "id": "extract-content" }],
      "scanners": {
        "include": [
          {
            "tags": {
              "category": "pii"
            }
          },
          { "id": "mastercard-2x2" }
        ],
        "exclude": [{ "id": "mastercard-4x4" }]
      },
    }
  ]
}

Related Jiras: APPSEC-59429

@Anilm3
Anilm3 requested a review from a team as a code owner September 27, 2025 16:48
@codecov-commenter

codecov-commenter commented Sep 27, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.23%. Comparing base (bf56f8c) to head (f4d9ef6).
⚠️ Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
src/builder/processor_builder.hpp 60.00% 1 Missing and 1 partial ⚠️
src/builder/processor_builder.cpp 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   85.24%   85.23%   -0.01%     
==========================================
  Files         186      186              
  Lines        9364     9387      +23     
  Branches     4151     4170      +19     
==========================================
+ Hits         7982     8001      +19     
- Misses        551      552       +1     
- Partials      831      834       +3     
Flag Coverage Δ
waf_test 85.23% <91.17%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 27, 2025

Copy link
Copy Markdown

Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 89560336 90005160 0.00%
darwin-arm64::libddwaf.a.stripped 4545616 4579568 0.00%
darwin-arm64::libddwaf.dylib 1960784 1963024 0.00%
darwin-universal::libddwaf.a 180532808 181418872 0.00%
darwin-universal::libddwaf.a.stripped 9690824 9765392 0.00%
darwin-universal::libddwaf.dylib 4139856 4142096 0.00%
darwin-x86_64::libddwaf.a 90972424 91413664 0.00%
darwin-x86_64::libddwaf.a.stripped 5145160 5185776 0.00%
darwin-x86_64::libddwaf.dylib 2147776 2150896 0.00%
linux-aarch64::libddwaf.a 72647358 73157156 0.00%
linux-aarch64::libddwaf.a.stripped 11778162 11850392 0.00%
linux-aarch64::libddwaf.so 2453368 2463248 0.00%
linux-armv7::libddwaf.a 64279684 64716944 0.00%
linux-armv7::libddwaf.a.stripped 10783356 10851172 0.00%
linux-armv7::libddwaf.so 2138996 2148636 0.00%
linux-i386::libddwaf.a 62427430 62841140 0.00%
linux-i386::libddwaf.a.stripped 9321362 9378668 0.00%
linux-i386::libddwaf.so 2382908 2392756 0.00%
linux-x86_64::libddwaf.a 73129494 73643724 0.00%
linux-x86_64::libddwaf.a.stripped 11599138 11669544 0.00%
linux-x86_64::libddwaf.so 2649632 2660048 0.00%
windows-arm64::ddwaf.dll 4769280 4788224 0.00%
windows-arm64::ddwaf.lib 11698 11698 0.00%
windows-arm64::ddwaf_static.lib 57431616 57913412 0.00%
windows-win32::ddwaf.dll 3356160 3368448 0.00%
windows-win32::ddwaf.lib 11922 11922 0.00%
windows-win32::ddwaf_static.lib 49113786 49534220 0.00%
windows-x64::ddwaf.dll 4088832 4101632 0.00%
windows-x64::ddwaf.lib 11698 11698 0.00%
windows-x64::ddwaf_static.lib 56948354 57409498 0.00%
windows-x86_64::libddwaf.a 6464848 6539844 0.01%
windows-x86_64::libddwaf.dll 18860246 18890803 0.00%
windows-x86_64::libddwaf.dll.a 31948 31948 0.00%

@Anilm3
Anilm3 force-pushed the anilm3/incremental-processor-overrides branch from c6fb7c9 to 0d4133b Compare September 27, 2025 19:20
@pr-commenter

pr-commenter Bot commented Sep 27, 2025

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-09-29 19:14:35

Comparing candidate commit f4d9ef6 in PR branch anilm3/incremental-processor-overrides with baseline commit bf56f8c in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random.clang

  • 🟥 execution_time [+40.028ms; +40.041ms] or [+16.422%; +16.428%]

@pr-commenter

pr-commenter Bot commented Sep 27, 2025

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-09-29 19:15:51

Comparing candidate commit f4d9ef6 in PR branch anilm3/incremental-processor-overrides with baseline commit bf56f8c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Sep 27, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-09-29 11:43:05

Comparing candidate commit 13a431d in PR branch anilm3/incremental-processor-overrides with baseline commit bf56f8c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@DataDog DataDog deleted a comment from chatgpt-codex-connector Bot Sep 29, 2025
@DataDog DataDog deleted a comment from chatgpt-codex-connector Bot Sep 29, 2025
Comment thread src/builder/processor_builder.cpp Outdated
@Anilm3
Anilm3 enabled auto-merge (squash) September 29, 2025 19:07
@Anilm3
Anilm3 merged commit b9b159e into master Sep 29, 2025
56 of 57 checks passed
@Anilm3
Anilm3 deleted the anilm3/incremental-processor-overrides branch September 29, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants