Skip to content

Replace number types with integer for integer-only attributes#457

Merged
Anilm3 merged 1 commit into
masterfrom
improve-schemas-typing
Sep 22, 2025
Merged

Replace number types with integer for integer-only attributes#457
Anilm3 merged 1 commit into
masterfrom
improve-schemas-typing

Conversation

@Strech

@Strech Strech commented Sep 22, 2025

Copy link
Copy Markdown
Member

This is a change for some number attributes that are actually integers-only. Like path to the key and duration.

In addition the result.json schema get the required attribute. And some conventional formatting for short definitions was applied.

@Strech
Strech requested a review from a team as a code owner September 22, 2025 13:34
@codecov-commenter

codecov-commenter commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.23%. Comparing base (2a8a7f6) to head (cc26c3b).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files         186      186           
  Lines        9347     9347           
  Branches     4138     4138           
=======================================
  Hits         7967     7967           
  Misses        551      551           
  Partials      829      829
Flag Coverage Δ
waf_test 85.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Anilm3
Anilm3 enabled auto-merge (squash) September 22, 2025 13:47
@Strech

Strech commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-22 13:55:52 UTC ℹ️ Start processing command /merge

2025-09-22 13:56:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-22 14:01:52 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@github-actions

github-actions Bot commented Sep 22, 2025

Copy link
Copy Markdown

Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 89560336 89863936 0.00%
darwin-arm64::libddwaf.a.stripped 4545616 4570736 0.00%
darwin-arm64::libddwaf.dylib 1960784 1963024 0.00%
darwin-universal::libddwaf.a 180532808 181145200 0.00%
darwin-universal::libddwaf.a.stripped 9690824 9743768 0.00%
darwin-universal::libddwaf.dylib 4139856 4142096 0.00%
darwin-x86_64::libddwaf.a 90972424 91281216 0.00%
darwin-x86_64::libddwaf.a.stripped 5145160 5172984 0.00%
darwin-x86_64::libddwaf.dylib 2147776 2150888 0.00%
linux-aarch64::libddwaf.a 72647358 73024804 0.00%
linux-aarch64::libddwaf.a.stripped 11778162 11827136 0.00%
linux-aarch64::libddwaf.so 2453368 2457520 0.00%
linux-armv7::libddwaf.a 64279684 64592594 0.00%
linux-armv7::libddwaf.a.stripped 10783356 10826670 0.00%
linux-armv7::libddwaf.so 2138996 2142652 0.00%
linux-i386::libddwaf.a 62427430 62722222 0.00%
linux-i386::libddwaf.a.stripped 9321362 9358698 0.00%
linux-i386::libddwaf.so 2382908 2386948 0.00%
linux-x86_64::libddwaf.a 73129494 73506156 0.00%
linux-x86_64::libddwaf.a.stripped 11599138 11645840 0.00%
linux-x86_64::libddwaf.so 2649632 2654128 0.00%
windows-arm64::ddwaf.dll 4769280 4779008 0.00%
windows-arm64::ddwaf.lib 11698 11698 0.00%
windows-arm64::ddwaf_static.lib 57431616 57794512 0.00%
windows-win32::ddwaf.dll 3356160 3361792 0.00%
windows-win32::ddwaf.lib 11922 11922 0.00%
windows-win32::ddwaf_static.lib 49113786 49442278 0.00%
windows-x64::ddwaf.dll 4088832 4094976 0.00%
windows-x64::ddwaf.lib 11698 11698 0.00%
windows-x64::ddwaf_static.lib 56948354 57312036 0.00%
windows-x86_64::libddwaf.a 6464848 6516132 0.00%
windows-x86_64::libddwaf.dll 18860246 18875018 0.00%
windows-x86_64::libddwaf.dll.a 31948 31948 0.00%

@pr-commenter

pr-commenter Bot commented Sep 22, 2025

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-09-22 13:57:24

Comparing candidate commit cc26c3b in PR branch improve-schemas-typing with baseline commit 2a8a7f6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Sep 22, 2025

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-09-22 13:57:28

Comparing candidate commit cc26c3b in PR branch improve-schemas-typing with baseline commit 2a8a7f6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 merged commit 5c5c376 into master Sep 22, 2025
57 of 58 checks passed
@Anilm3
Anilm3 deleted the improve-schemas-typing branch September 22, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anilm3 Anilm3 Anilm3 approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Strech @codecov-commenter @Anilm3