Skip to content

[v2] Return DDWAF_MATCH when there are events, attributes or actions#455

Merged
Anilm3 merged 3 commits into
anilm3/v2from
anilm3/expand-match-to-attributes-and-actions
Sep 19, 2025
Merged

[v2] Return DDWAF_MATCH when there are events, attributes or actions#455
Anilm3 merged 3 commits into
anilm3/v2from
anilm3/expand-match-to-attributes-and-actions

Conversation

@Anilm3

@Anilm3 Anilm3 commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR expands the cases in which DDWAF_MATCH is returned to include those in which attributes and actions are provided.

@Anilm3
Anilm3 requested a review from a team as a code owner September 18, 2025 21:20
@codecov-commenter

codecov-commenter commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (1cd16ec) to head (0bb6481).

Additional details and impacted files 
@@              Coverage Diff              @@
##           anilm3/v2     #455      +/-   ##
=============================================
- Coverage      84.84%   84.84%   -0.01%     
=============================================
  Files            190      190              
  Lines           9788     9789       +1     
  Branches        4262     4263       +1     
=============================================
  Hits            8305     8305              
  Misses           613      613              
- Partials         870      871       +1
Flag Coverage Δ
waf_test 84.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter

pr-commenter Bot commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-09-19 12:15:56

Comparing candidate commit 0bb6481 in PR branch anilm3/expand-match-to-attributes-and-actions with baseline commit 1cd16ec in branch anilm3/v2.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-09-19 12:16:03

Comparing candidate commit 0bb6481 in PR branch anilm3/expand-match-to-attributes-and-actions with baseline commit 1cd16ec in branch anilm3/v2.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@github-actions

github-actions Bot commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 89560336 94534760 0.05%
darwin-arm64::libddwaf.a.stripped 4545616 4871768 0.07%
darwin-arm64::libddwaf.dylib 1960784 2033056 0.03%
darwin-universal::libddwaf.a 180532808 190701992 0.05%
darwin-universal::libddwaf.a.stripped 9690824 10379968 0.07%
darwin-universal::libddwaf.dylib 4139856 4277664 0.03%
darwin-x86_64::libddwaf.a 90972424 96167184 0.05%
darwin-x86_64::libddwaf.a.stripped 5145160 5508152 0.07%
darwin-x86_64::libddwaf.dylib 2147776 2222160 0.03%
linux-aarch64::libddwaf.a 72647358 75787446 0.04%
linux-aarch64::libddwaf.a.stripped 11778162 12257994 0.04%
linux-aarch64::libddwaf.so 2453368 2493512 0.01%
linux-armv7::libddwaf.a 64279684 66946270 0.04%
linux-armv7::libddwaf.a.stripped 10783356 11239826 0.04%
linux-armv7::libddwaf.so 2138996 2152784 0.00%
linux-i386::libddwaf.a 62427430 65054446 0.04%
linux-i386::libddwaf.a.stripped 9321362 9727162 0.04%
linux-i386::libddwaf.so 2382908 2415660 0.01%
linux-x86_64::libddwaf.a 73129494 76268764 0.04%
linux-x86_64::libddwaf.a.stripped 11599138 12052680 0.03%
linux-x86_64::libddwaf.so 2649632 2687056 0.01%
windows-arm64::ddwaf.dll 4769280 4903936 0.02%
windows-arm64::ddwaf.lib 11698 16410 0.40%
windows-arm64::ddwaf_static.lib 57431616 60206374 0.04%
windows-win32::ddwaf.dll 3356160 3467264 0.03%
windows-win32::ddwaf.lib 11922 16726 0.40%
windows-win32::ddwaf_static.lib 49113786 51789656 0.05%
windows-x64::ddwaf.dll 4088832 4186112 0.02%
windows-x64::ddwaf.lib 11698 16410 0.40%
windows-x64::ddwaf_static.lib 56948354 59724328 0.04%

@pr-commenter

pr-commenter Bot commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-09-19 12:30:52

Comparing candidate commit 0bb6481 in PR branch anilm3/expand-match-to-attributes-and-actions with baseline commit 1cd16ec in branch anilm3/v2.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Base automatically changed from anilm3/update-logger to anilm3/v2 September 19, 2025 11:53
cataphract
cataphract approved these changes Sep 19, 2025
View reviewed changes

@cataphract cataphract left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change to the public API, so it should go on UPGRADING

@Anilm3
Anilm3 merged commit 43b77f2 into anilm3/v2 Sep 19, 2025
54 checks passed
@Anilm3
Anilm3 deleted the anilm3/expand-match-to-attributes-and-actions branch September 19, 2025 13:50
Anilm3 added a commit that referenced this pull request Oct 1, 2025
@Anilm3
libddwaf v2 (#377)
482b5df 
* Object view: read only abstraction to ddwaf_object (#341)
* [v2] Remove mingw builds (#381)
* Writable objects: owned and borrowed object and object limits removal (#378, #382)
* [v2] Refactor and improve object types (#387)
* [v2] Update unit tests to use new abstractions (#389)
* [v2] Update `raw_configuration` type to use `object_view` (#390)
* [v2] Remove remaining uses of ddwaf_object in `src` and `tests/unit` (#391)
* [v2] JWT Decoding Processor (#401)
* [v2] First iteration of object layout changes (#394)
* Split context data insertion from evaluation (#407)
* [v2] Second iteration of object layout changes (#408)
* [v2] Add new fingerprint and object view tests (#414)
* Reenable attribute collector unit test (#415)
* [v2] Container view types (#413)
* Exclude assertions from coverage (#416)
* [v2] Use allocators internally instead of malloc/free and stop generating zero-terminated strings (#418)
* Add memory resource to owned and borrowed objects (#428)
* [v2] Propagate allocators from context (#420)
* [v2] Update interface and expose allocators (#427)
* Refactor evaluation stages out of the context (#442)
* Subcontext: replace ephemerals with a new scope with user-defined lifetime derived from the context (#443)
* Validator: Add support for testing subcontexts and attributes (#451)
* [v2] Pass allocator to context and subcontext eval and add new allocators (#452)
* Update logger to avoid dependencies on ddwaf.h (#453)
* [v2] Return DDWAF_MATCH when there are events, attributes or actions (#455)
* [v2] Cleanup: remove exclusion namespace and some redundant references (#456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataphract cataphract cataphract approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anilm3 @codecov-commenter @cataphract