match_regex_with_checksum operator: match and verify regexes with a checksum#450
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 85.14% 85.23% +0.09%
==========================================
Files 180 186 +6
Lines 9289 9347 +58
Branches 4115 4138 +23
==========================================
+ Hits 7909 7967 +58
Misses 551 551
Partials 829 829
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Artifact Size Comparison 📦
|
829178f to
ec17221
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Benchmarks clangBenchmark execution time: 2025-09-17 16:28:28 Comparing candidate commit 59b454a in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:global-benchmark.random.clang
|
Benchmarks gccBenchmark execution time: 2025-09-18 14:52:36 Comparing candidate commit e59cc64 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Benchmarks clang-pgoBenchmark execution time: 2025-09-12 15:39:21 Comparing candidate commit 368ff3b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
5ca1053 to
09381f6
Compare
09381f6 to
2603ae0
Compare
|
@codex review |
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
b4458c6 to
68e4663
Compare
Anilm3
changed the title
Anilm3
changed the title
68e4663 to
0e45fc7
Compare
0e45fc7 to
fd278e1
Compare
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
b53faa7 to
3a1ce52
Compare
3a1ce52 to
bd40fe8
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
4 participants
This PR introduces a new operator with the goal of being able to match identifiers which can be validated with a checksum. The operator is called
match_regex_with_checksum, as the regex is used to extract the identifier and the checksum to validate that the identifier matches a known criteria. For example, this operator may be used to determine if a pattern resembling a credit card is indeed a credit card.The operator requires the same parameters as a regex, in addition to a checksum algorithm which has to be specified by name. In this PR, a simple version of the luhn check digit algorithm has been implemented.