Skip to content

Support float status codes in configuration#448

Merged
Anilm3 merged 2 commits into
masterfrom
anilm3/float-status-code
Sep 3, 2025
Merged

Support float status codes in configuration#448
Anilm3 merged 2 commits into
masterfrom
anilm3/float-status-code

Conversation

@Anilm3

@Anilm3 Anilm3 commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator

Following up on #441, this PR adds support for validating status codes of type float (actually double).

@Anilm3
Anilm3 requested a review from a team as a code owner September 3, 2025 09:12
@codecov-commenter

codecov-commenter commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.14%. Comparing base (bbe9915) to head (49991a2).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
src/configuration/actions_parser.cpp 70.58% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   85.15%   85.14%   -0.02%     
==========================================
  Files         180      180              
  Lines        9283     9289       +6     
  Branches     4116     4115       -1     
==========================================
+ Hits         7905     7909       +4     
- Misses        550      551       +1     
- Partials      828      829       +1
Flag Coverage Δ
waf_test 85.14% <70.58%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 89505960 89560336 0.00%
darwin-arm64::libddwaf.a.stripped 4543304 4545616 0.00%
darwin-arm64::libddwaf.dylib 1960768 1960784 0.00%
darwin-universal::libddwaf.a 180426024 180532808 0.00%
darwin-universal::libddwaf.a.stripped 9685040 9690824 0.00%
darwin-universal::libddwaf.dylib 4139840 4139856 0.00%
darwin-x86_64::libddwaf.a 90920016 90972424 0.00%
darwin-x86_64::libddwaf.a.stripped 5141688 5145160 0.00%
darwin-x86_64::libddwaf.dylib 2147768 2147776 0.00%
linux-aarch64::libddwaf.a 72591856 72647358 0.00%
linux-aarch64::libddwaf.a.stripped 11765868 11778162 0.00%
linux-aarch64::libddwaf.so 2452088 2453368 0.00%
linux-armv7::libddwaf.a 64215966 64279684 0.00%
linux-armv7::libddwaf.a.stripped 10768430 10783356 0.00%
linux-armv7::libddwaf.so 2137868 2138996 0.00%
linux-i386::libddwaf.a 62369460 62427430 0.00%
linux-i386::libddwaf.a.stripped 9311580 9321362 0.00%
linux-i386::libddwaf.so 2381300 2382908 0.00%
linux-x86_64::libddwaf.a 73077672 73129494 0.00%
linux-x86_64::libddwaf.a.stripped 11587372 11599138 0.00%
linux-x86_64::libddwaf.so 2648016 2649632 0.00%
windows-arm64::ddwaf.dll 4769280 4769280 0.00%
windows-arm64::ddwaf.lib 11698 11698 0.00%
windows-arm64::ddwaf_static.lib 57421530 57431616 0.00%
windows-win32::ddwaf.dll 3355648 3356160 0.00%
windows-win32::ddwaf.lib 11922 11922 0.00%
windows-win32::ddwaf_static.lib 49101898 49113786 0.00%
windows-x64::ddwaf.dll 4089344 4088832 0.00%
windows-x64::ddwaf.lib 11698 11698 0.00%
windows-x64::ddwaf_static.lib 56982106 56948354 0.00%
windows-x86_64::libddwaf.a 6457332 6464848 0.00%
windows-x86_64::libddwaf.dll 18853216 18860246 0.00%
windows-x86_64::libddwaf.dll.a 31948 31948 0.00%

@pr-commenter

pr-commenter Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-09-03 11:28:55

Comparing candidate commit 49991a2 in PR branch anilm3/float-status-code with baseline commit bbe9915 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-09-03 11:45:21

Comparing candidate commit 49991a2 in PR branch anilm3/float-status-code with baseline commit bbe9915 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3 Anilm3 changed the title Support float status codes Support float status codes in configuration Sep 3, 2025
cataphract
cataphract approved these changes Sep 3, 2025
View reviewed changes
Comment thread src/configuration/actions_parser.cpp Outdated
@pr-commenter

pr-commenter Bot commented Sep 3, 2025

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-09-03 10:33:32

Comparing candidate commit 762a9d4 in PR branch anilm3/float-status-code with baseline commit bbe9915 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 merged commit 8273d8f into master Sep 3, 2025
57 checks passed
@Anilm3
Anilm3 deleted the anilm3/float-status-code branch September 3, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cataphract cataphract cataphract approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anilm3 @codecov-commenter @cataphract