Skip to content

Add support for building and testing windows arm64#440

Merged
Anilm3 merged 3 commits into
DataDog:masterfrom
MGN-GIT:win_arm64
Aug 20, 2025
Merged

Add support for building and testing windows arm64#440
Anilm3 merged 3 commits into
DataDog:masterfrom
MGN-GIT:win_arm64

Conversation

@MGN-GIT

@MGN-GIT MGN-GIT commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

PR Description:

  • The adoption of Windows on ARM (WoA) devices is steadily increasing, yet many libraries are still not available for this platform.
  • GitHub Actions now offer native CI runners for Windows on ARM devices (windows-11-arm), enabling automated builds and testing.
  • Currently, official libddwaf binary are not provided for Windows ARM64 and thus users/developers were facing difficulties using libddwaf library natively.
  • This PR introduces support for building libddwaf library on Windows ARM64, improving accessibility for developers and end users on this emerging platform.

@MGN-GIT
MGN-GIT requested a review from a team as a code owner August 17, 2025 11:01
@MGN-GIT MGN-GIT mentioned this pull request Aug 19, 2025
Closed
@khmyznikov khmyznikov mentioned this pull request Aug 17, 2025
Open
@codecov-commenter

codecov-commenter commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (a37a7a2) to head (6b1c457).
⚠️ Report is 37 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         179      179           
  Lines        9085     9085           
  Branches     4001     4001           
=======================================
  Hits         7755     7755           
  Misses        517      517           
  Partials      813      813
Flag Coverage Δ
waf_test 85.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Anilm3
Anilm3 requested changes Aug 20, 2025
View reviewed changes

@Anilm3 Anilm3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I've made some small suggestions.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
@MGN-GIT

MGN-GIT commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@Anilm3 thanks for the suggestions, made the relevant changes

@Anilm3
Anilm3 merged commit 4492d25 into DataDog:master Aug 20, 2025
53 of 54 checks passed
@MGN-GIT

MGN-GIT commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

Hi @Anilm3, kindly can you share some information regarding the ETA for the next release. Having release for windows arm64 for libddwaf package would help us to get moving forward to support dd-trace-py wheels for windows arm64.

Thank you so much!

@Anilm3

Anilm3 commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

Hi @Anilm3, kindly can you share some information regarding the ETA for the next release. Having release for windows arm64 for libddwaf package would help us to get moving forward to support dd-trace-py wheels for windows arm64.

Thank you so much!

Hi @Greenie0701, there are a few things we'd like to include in the next release so the earliest ETA would be early next week.

@MGN-GIT MGN-GIT mentioned this pull request Aug 28, 2025
Closed
@MGN-GIT

MGN-GIT commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anilm3 Anilm3 Anilm3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MGN-GIT @codecov-commenter @Anilm3