Accept empty and inconsequential configurations#437
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 85.30% 85.45% +0.15%
==========================================
Files 176 176
Lines 9031 9029 -2
Branches 3968 3966 -2
==========================================
+ Hits 7704 7716 +12
+ Misses 512 511 -1
+ Partials 815 802 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Artifact Size Comparison 📦
|
ed63375 to
4f1c69a
Compare
Benchmarks clangBenchmark execution time: 2025-08-01 11:26:55 Comparing candidate commit caeb1d2 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:global-benchmark.random.clang
|
Benchmarks gccBenchmark execution time: 2025-08-01 11:28:28 Comparing candidate commit caeb1d2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
4f1c69a to
6b6913a
Compare
Benchmarks clang-pgoBenchmark execution time: 2025-08-01 10:16:03 Comparing candidate commit 6b6913a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
3 participants
This PR modifies the behaviour of the builder to allow configurations which have no side-effects, i.e. inconsequential configurations. These are configurations which have no errors but also no loadable items, for example, a configuration may contain rules with a
max_versionbelow the current one, therefore it's perfectly valid but nothing will be loaded. Similarly, a configuration may be entirely empty or contain only empty sections.While these configs don't provide any value, they also cause no harm, therefore they are now accepted instead of rejected.
In addition, this PR also removes the
null_ruleset_infoandbase_ruleset_infoclasses as production deployments will always require diagnostics.