Skip to content

[v2] Exclude assertions from coverage#416

Merged
Anilm3 merged 1 commit into
anilm3/v2from
anilm3/exclude-assertions-from-coverage
Jun 10, 2025
Merged

[v2] Exclude assertions from coverage#416
Anilm3 merged 1 commit into
anilm3/v2from
anilm3/exclude-assertions-from-coverage

Conversation

@Anilm3

@Anilm3 Anilm3 commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

As the title suggests, this PR excludes assertions from coverage as they're not meant to be tested.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (1271c37) to head (f6f7e7e).

Additional details and impacted files
@@              Coverage Diff              @@
##           anilm3/v2     #416      +/-   ##
=============================================
+ Coverage      85.76%   85.99%   +0.23%     
=============================================
  Files            176      176              
  Lines           9088     9063      -25     
  Branches        3860     3835      -25     
=============================================
  Hits            7794     7794              
  Misses           492      492              
+ Partials         802      777      -25     
Flag Coverage Δ
waf_test 85.99% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter

pr-commenter Bot commented Jun 9, 2025

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-06-09 17:01:19

Comparing candidate commit f6f7e7e in PR branch anilm3/exclude-assertions-from-coverage with baseline commit 1271c37 in branch anilm3/v2.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Jun 9, 2025

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-06-09 17:05:01

Comparing candidate commit f6f7e7e in PR branch anilm3/exclude-assertions-from-coverage with baseline commit 1271c37 in branch anilm3/v2.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@pr-commenter

pr-commenter Bot commented Jun 9, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-06-09 17:17:56

Comparing candidate commit f6f7e7e in PR branch anilm3/exclude-assertions-from-coverage with baseline commit 1271c37 in branch anilm3/v2.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 marked this pull request as ready for review June 10, 2025 12:37
@Anilm3
Anilm3 requested a review from a team as a code owner June 10, 2025 12:37
@Anilm3
Anilm3 merged commit a4a0bad into anilm3/v2 Jun 10, 2025
@Anilm3
Anilm3 deleted the anilm3/exclude-assertions-from-coverage branch June 10, 2025 12:48
Anilm3 added a commit that referenced this pull request Oct 1, 2025
* Object view: read only abstraction to ddwaf_object (#341)
* [v2] Remove mingw builds (#381)
* Writable objects: owned and borrowed object and object limits removal (#378, #382)
* [v2] Refactor and improve object types (#387)
* [v2] Update unit tests to use new abstractions (#389)
* [v2] Update `raw_configuration` type to use `object_view` (#390)
* [v2] Remove remaining uses of ddwaf_object in `src` and `tests/unit` (#391)
* [v2] JWT Decoding Processor (#401)
* [v2] First iteration of object layout changes (#394)
* Split context data insertion from evaluation (#407)
* [v2] Second iteration of object layout changes (#408)
* [v2] Add new fingerprint and object view tests (#414)
* Reenable attribute collector unit test (#415)
* [v2] Container view types (#413)
* Exclude assertions from coverage (#416)
* [v2] Use allocators internally instead of malloc/free and stop generating zero-terminated strings (#418)
* Add memory resource to owned and borrowed objects (#428)
* [v2] Propagate allocators from context (#420)
* [v2] Update interface and expose allocators (#427)
* Refactor evaluation stages out of the context (#442)
* Subcontext: replace ephemerals with a new scope with user-defined lifetime derived from the context (#443)
* Validator: Add support for testing subcontexts and attributes (#451)
* [v2] Pass allocator to context and subcontext eval and add new allocators (#452)
* Update logger to avoid dependencies on ddwaf.h (#453)
* [v2] Return DDWAF_MATCH when there are events, attributes or actions (#455)
* [v2] Cleanup: remove exclusion namespace and some redundant references (#456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants