Skip to content

Replace re2::StringPiece with std::string_view#412

Merged
Anilm3 merged 3 commits into
masterfrom
anilm3/replace-re2-stringpiece
Jun 6, 2025
Merged

Replace re2::StringPiece with std::string_view#412
Anilm3 merged 3 commits into
masterfrom
anilm3/replace-re2-stringpiece

Conversation

@Anilm3

@Anilm3 Anilm3 commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

The latest version of re2 long ago replaced re2::StringPiece with absl::string_view. This PR follows the same strategy but instead of using absl::string_view I decided to use std::string_view to avoid the extra (extremely large and cumbersome) dependency.

@codecov-commenter

codecov-commenter commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (31c61e9) to head (231abf9).
⚠️ Report is 50 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         175      175           
  Lines        8946     8946           
  Branches     3924     3924           
=======================================
  Hits         7634     7634           
  Misses        504      504           
  Partials      808      808           
Flag Coverage Δ
waf_test 85.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter

pr-commenter Bot commented Jun 4, 2025

Copy link
Copy Markdown

Benchmarks clang

Benchmark execution time: 2025-06-04 20:04:28

Comparing candidate commit 231abf9 in PR branch anilm3/replace-re2-stringpiece with baseline commit 31c61e9 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random.clang

  • 🟥 execution_time [+17.394ms; +17.418ms] or [+6.551%; +6.560%]

@pr-commenter

pr-commenter Bot commented Jun 4, 2025

Copy link
Copy Markdown

Benchmarks gcc

Benchmark execution time: 2025-06-04 20:05:31

Comparing candidate commit 231abf9 in PR branch anilm3/replace-re2-stringpiece with baseline commit 31c61e9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 marked this pull request as ready for review June 4, 2025 15:17
@Anilm3
Anilm3 requested a review from a team as a code owner June 4, 2025 15:17
@pr-commenter

pr-commenter Bot commented Jun 4, 2025

Copy link
Copy Markdown

Benchmarks clang-pgo

Benchmark execution time: 2025-06-04 20:18:59

Comparing candidate commit 231abf9 in PR branch anilm3/replace-re2-stringpiece with baseline commit 31c61e9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3
Anilm3 merged commit 0675191 into master Jun 6, 2025
@Anilm3
Anilm3 deleted the anilm3/replace-re2-stringpiece branch June 6, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants