Replace re2::StringPiece with std::string_view#412
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 175 175
Lines 8946 8946
Branches 3924 3924
=======================================
Hits 7634 7634
Misses 504 504
Partials 808 808
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmarks clangBenchmark execution time: 2025-06-04 20:04:28 Comparing candidate commit 231abf9 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:global-benchmark.random.clang
|
Benchmarks gccBenchmark execution time: 2025-06-04 20:05:31 Comparing candidate commit 231abf9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Benchmarks clang-pgoBenchmark execution time: 2025-06-04 20:18:59 Comparing candidate commit 231abf9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
The latest version of re2 long ago replaced
re2::StringPiecewithabsl::string_view. This PR follows the same strategy but instead of usingabsl::string_viewI decided to usestd::string_viewto avoid the extra (extremely large and cumbersome) dependency.