#47 (comment)

TBF I'm not certain it works as expected, I'll try quickly adding a Windows build 🤞

#47 (comment)

TBF I'm not certain it works as expected, I'll try quickly adding a Windows build 🤞

@gleocadie fyi, as you have interests in building on windows

Ok, I've tried compiling locally for windows using cross , and it actually doesn't work.

I get this error

% cross check --target x86_64-pc-windows-gnu

error[E0412]: cannot find type `UnixStream` in module `tokio::net`
  --> ddprof-exporter/src/connector/conn_stream.rs:21:44
   |
21 |         Udp{ #[pin] transport: tokio::net::UnixStream },
   |                                            ^^^^^^^^^^ not found in `tokio::net`

error[E0599]: no variant named `Udp` found for enum `ConnStream`
  --> ddprof-exporter/src/connector/conn_stream.rs:21:9
   |
13 | / pin_project! {
14 | |     #[derive(Debug)]
15 | |     #[project = ConnStreamProj]
16 | |     pub enum ConnStream {
...  |
21 | |         Udp{ #[pin] transport: tokio::net::UnixStream },
   | |         ^^^ variant not found in `ConnStream`
22 | |     }
23 | | }
   | |_- variant `Udp` not found here

Maybe if the cleaner code is worth it, we could try using https://github.com/taiki-e/pin-project instead of pin_project_lite as it supports more features.

Or we just write the projection code ourselves. Looking at the kind of code generated by pin-project https://github.com/taiki-e/pin-project/blob/HEAD/examples/struct-default-expanded.rs , anf removing the cruft it doesn't look to bad.

#47 (comment)
TBF I'm not certain it works as expected, I'll try quickly adding a Windows build 🤞

@gleocadie fyi, as you have interests in building on windows

thanks for the heads up

Thanks @paullegranddc - with your suggestion I reimplemented the project() method.
Its a bit verbose but not by much - explicit and visible use of Unsafe is a bit of an eyesore.

https://github.com/DataDog/libddprof/pull/47/files#diff-1d9699d6f15d9c4af24ade58efdaadaa21f28f7150cdbb6a95f65c20e8eca6f9R42-R60

Edit: after sleeing on this I decided to switch back to pin_project (non-lite) just to reduce the number of visible code lines and the unsafe eyesore (out of sight out of mind 😂 ).

Thanks All for the review!