Github CI lint and and tests#46
Conversation
3735be2 to
7284ad2
Compare
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
👍 Looks GREAT to me, thanks for this!
| test: | ||
| name: cargo test --workspace | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v2 | ||
| - name: Cache | ||
| uses: ./.github/actions/cache | ||
| - run: cargo build --workspace --verbose | ||
| - run: cargo test --workspace --verbose |
There was a problem hiding this comment.
Can I convince you to also build the examples/ffi? We've had issues with them bitrotting in the past so it'd be great to have them running in CI :)
There was a problem hiding this comment.
Yeah, we should definitely add that build to the CI. But it seems I need to basically build the end artifact to make cmake happy.
I have another proposal in progress, which builds the world using bazel its not handling the example yet.
But once it does - it would just be this invocation in the CI for build checking everything:
bazel build //...Bazel or no bazel, we'll definitely need to check this in CI at some point. So I can take a note, to return to it, if we decide bazel sucks too much :)
r1viollet
left a comment
r1viollet
left a comment
There was a problem hiding this comment.
This is nice !
Thanks for this PR
|
Thanks all for the review ! |
4 participants
What does this PR do?
Adds basic CI Lints and Tests in Github actions.
Motivation
Quick feedback and lint check for submitted PRs