[crashtracking]: upgrade libdatadog for crashtracking to 26.0.0#61
Merged
Conversation
gyuheon0h
marked this pull request as ready for review
February 5, 2026 03:20
szegedi
previously approved these changes
Feb 5, 2026
szegedi
left a comment
szegedi
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good to me; as long as the tests pass it's okay. I also had a fix for that crypto initialization thing in the top commit in the https://github.com/DataDog/libdatadog-nodejs/commits/szegedi/crashtracker-18/ branch, is that no longer needed?
Contributor
Author
Hmmm I don't have context on this; i'll investigate. Yup, can remove the crypto init |
Add pre-test script to build workflow for artifact handling
…taDog/libdatadog-nodejs into gyuheon0h/crashtracking-libdd-upgrade
rochdev
reviewed
Feb 5, 2026
rochdev
reviewed
Feb 5, 2026
rochdev
approved these changes
Feb 5, 2026
rochdev
left a comment
rochdev
left a comment
Member
There was a problem hiding this comment.
A few questions but no blocker!
gyuheon0h
added a commit
that referenced
this pull request
Feb 11, 2026
* Upgrade to v26 and fix compat issues + serialization workaround * Serde + napi demo * remove demo code; keep commit for history * clean up * members being weird * Remove crypto init and make test resilient * Include pre-test script in build.yml Add pre-test script to build workflow for artifact handling * Remove crypto init * Revert build yml file
Merged
szegedi
pushed a commit
that referenced
this pull request
Feb 12, 2026
* Upgrade to v26 and fix compat issues + serialization workaround * Serde + napi demo * remove demo code; keep commit for history * clean up * members being weird * Remove crypto init and make test resilient * Include pre-test script in build.yml Add pre-test script to build workflow for artifact handling * Remove crypto init * Revert build yml file
bengl
pushed a commit
that referenced
this pull request
Mar 17, 2026
* Upgrade to v26 and fix compat issues + serialization workaround * Serde + napi demo * remove demo code; keep commit for history * clean up * members being weird * Remove crypto init and make test resilient * Include pre-test script in build.yml Add pre-test script to build workflow for artifact handling * Remove crypto init * Revert build yml file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do
Upgrades libdatadog for crashtracking to v26
When passing
signals: []to crashtracker, signal handlers were not installed, causing crashes to besilently ignored.
This upgrade was delayed due to issue described here: #54
Root Cause:
NAPI's
env.from_js_value()uses serde deserialization which bypassesCrashtrackerConfiguration::new().The constructor converts empty signals to default signals (SIGBUS, SIGABRT, SIGSEGV, SIGILL), but this
logic never runs when deserializing from JavaScript.
Commit with reproducible issue
Solution:
Added
apply_default_signals()helper incrates/crashtracker/src/lib.rsthat detects empty signals afterdeserialization and reconstructs the config using
new()to apply defaults. Applied in bothinit()andupdate_config().Additional notes:
We could have just bypassed this by explicitly listing out signal numbers, but the point is that we want the tracer/application actually running the crashtracker to be able to configure this.
Testing:
Crashtracking test passes with
signals: []- crashes are now correctly captured and reported.Ticket: https://datadoghq.atlassian.net/jira/software/c/projects/PROF/boards/11?selectedIssue=PROF-13449