APMLP-350 Test ipv6 endpoint parsing#809
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 71.03% 71.03%
=======================================
Files 313 313
Lines 45900 45906 +6
=======================================
+ Hits 32604 32611 +7
+ Misses 13296 13295 -1
|
p-datadog
changed the title
marcotc
approved these changes
Jan 2, 2025
ivoanjo
approved these changes
Jan 3, 2025
ivoanjo
left a comment
ivoanjo
left a comment
Member
There was a problem hiding this comment.
👍 Thanks for improving the tests! I've also gone ahead and added you to https://github.com/orgs/DataDog/teams/libdatadog-ruby so you should have write access to this repository, to make it easier for future contributions :)
Member
|
The "pull request triager" seems to not be working (maybe because this is coming from an external fork?), but I'm going to go ahead and merge this anyway. (Any issues or concerns -- ping me :D ) |
Member
|
Update: After merging this to master, CI is green as expected:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds tests for parsing endpoints using ipv6 addresses, valid and malformed (since dd-trace-rb somehow generates the malformed one).
Motivation
Debugging a crash in dd-trace-rb when agent host is set to ipv6 address
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Unit tests are added, there is no change in code