Merged
Conversation
bwoebi
force-pushed
the
bob/sidecar-watchdog
branch
from
d0f2361 to
9115d18
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 73.64% 73.59% -0.05%
==========================================
Files 255 255
Lines 36896 36924 +28
==========================================
+ Hits 27171 27174 +3
- Misses 9725 9750 +25
|
BenchmarksComparisonBenchmark execution time: 2024-09-24 13:42:13 Comparing candidate commit fbdf3c4 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:credit_card/is_card_number_no_luhn/ 378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
cataphract
approved these changes
Sep 23, 2024
bantonsson
approved these changes
Sep 24, 2024
|
|
||
| let interval = self.interval.period(); | ||
| std::thread::spawn(move || { | ||
| let mut repeats = false; |
Contributor
There was a problem hiding this comment.
I can see what the code does and this variable is named after that, but maybe call it stuck or maybe_stuck?
| std::thread::sleep(interval); | ||
| let current = still_alive_thread.load(Ordering::Relaxed); | ||
| if last != current { | ||
| if current == u32::MAX { |
Contributor
There was a problem hiding this comment.
A comment about this constant or naming it SHUTDOWN would make things clearer.
pierotibou
reviewed
Sep 24, 2024
If the sidecar hangs, it can cause every process trying to write to it to be much slower. Better kill it once in doubt. Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/sidecar-watchdog
branch
from
97e5f75 to
fbdf3c4
Compare
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the sidecar hangs, it can cause every process trying to write to it to be much slower.
Better kill it once in doubt.