Skip to content

Upstream dogstatsd refactors#617

Merged
alexgallotta merged 32 commits intomainfrom
upstream-dogstatsd-refactors
Sep 23, 2024
Merged

Upstream dogstatsd refactors#617
alexgallotta merged 32 commits intomainfrom
upstream-dogstatsd-refactors

Conversation

@alexgallotta
Copy link
Copy Markdown
Contributor

@alexgallotta alexgallotta commented Sep 9, 2024

  • remove extra structs not needed
  • fixed false positive wrong tag format
  • optimization: avoid extra sorting for id
  • optimization: use ustr everywhere for tags

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 9, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-09-23 18:16:45

Comparing candidate commit 17576b4 in PR branch upstream-dogstatsd-refactors with baseline commit 5635814 in branch main.

Found 18 performance improvements and 18 performance regressions! Performance is the same for 15 metrics, 2 unstable metrics.

scenario:benching string interning on wordpress profile

  • 🟩 execution_time [-5.004µs; -4.840µs] or [-3.460%; -3.347%]

scenario:credit_card/is_card_number/

  • 🟩 execution_time [-803.019ns; -802.743ns] or [-33.233%; -33.222%]
  • 🟩 throughput [+205902824.166op/s; +205981810.370op/s] or [+49.753%; +49.772%]

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+5.519µs; +5.899µs] or [+4.770%; +5.098%]
  • 🟥 throughput [-421637.972op/s; -393260.334op/s] or [-4.878%; -4.550%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+4.687µs; +5.085µs] or [+4.359%; +4.729%]
  • 🟥 throughput [-422555.416op/s; -388474.902op/s] or [-4.543%; -4.176%]

scenario:credit_card/is_card_number/37828224631

  • 🟩 execution_time [-803.284ns; -802.863ns] or [-33.241%; -33.224%]
  • 🟩 throughput [+205918650.313op/s; +206025359.341op/s] or [+49.761%; +49.787%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+2.668µs; +3.117µs] or [+2.524%; +2.948%]
  • 🟥 throughput [-273946.654op/s; -233600.084op/s] or [-2.896%; -2.469%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+5.372µs; +5.530µs] or [+5.047%; +5.196%]
  • 🟥 throughput [-464815.360op/s; -451083.262op/s] or [-4.947%; -4.801%]

scenario:credit_card/is_card_number_no_luhn/

  • 🟩 execution_time [-802.996ns; -802.731ns] or [-33.233%; -33.222%]
  • 🟩 throughput [+205916929.321op/s; +205990578.885op/s] or [+49.754%; +49.772%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+8.891µs; +9.005µs] or [+10.183%; +10.313%]
  • 🟥 throughput [-1071267.861op/s; -1057820.445op/s] or [-9.354%; -9.237%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟥 execution_time [+7.139µs; +7.421µs] or [+8.867%; +9.217%]
  • 🟥 throughput [-1052724.445op/s; -1010550.571op/s] or [-8.474%; -8.135%]

scenario:credit_card/is_card_number_no_luhn/37828224631

  • 🟩 execution_time [-802.859ns; -802.585ns] or [-33.230%; -33.218%]
  • 🟩 throughput [+205890739.119op/s; +205964336.238op/s] or [+49.745%; +49.763%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+6.503µs; +6.701µs] or [+8.425%; +8.681%]
  • 🟥 throughput [-1037602.048op/s; -1005526.098op/s] or [-8.009%; -7.761%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+5.185µs; +5.337µs] or [+4.863%; +5.006%]
  • 🟥 throughput [-447529.125op/s; -434671.187op/s] or [-4.771%; -4.634%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟩 execution_time [-8.832µs; -7.818µs] or [-3.197%; -2.830%]
  • 🟩 throughput [+105784.428op/s; +120543.319op/s] or [+2.923%; +3.331%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟩 execution_time [-5.649µs; -5.608µs] or [-20.118%; -19.969%]
  • 🟩 throughput [+8889457.884op/s; +8967640.570op/s] or [+24.962%; +25.182%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟩 execution_time [-2.424µs; -2.405µs] or [-14.995%; -14.883%]
  • 🟩 throughput [+10828628.245op/s; +10903107.729op/s] or [+17.501%; +17.622%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+9.408µs; +9.501µs] or [+5.083%; +5.133%]
  • 🟥 throughput [-263848.358op/s; -261346.737op/s] or [-4.883%; -4.837%]

scenario:normalization/normalize_trace/test_trace

  • 🟩 execution_time [-23.072ns; -17.618ns] or [-7.485%; -5.716%]

scenario:sql/obfuscate_sql_string

  • 🟩 execution_time [-2.156µs; -2.084µs] or [-2.960%; -2.861%]

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-97.129ns; -89.897ns] or [-3.496%; -3.235%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.615µs 2.685µs ± 0.025µs 2.685µs ± 0.006µs 2.690µs 2.738µs 2.745µs 2.751µs 2.45% -0.115 1.990 0.91% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.682µs; 2.688µs] or [-0.127%; +0.127%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 539.685µs 540.293µs ± 0.298µs 540.241µs ± 0.179µs 540.441µs 540.830µs 541.160µs 541.333µs 0.20% 0.829 0.791 0.05% 0.021µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1847290.285op/s 1850847.220op/s ± 1018.967op/s 1851026.924op/s ± 613.297op/s 1851574.705op/s 1852224.355op/s 1852836.725op/s 1852932.729op/s 0.10% -0.826 0.783 0.05% 72.052op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.065µs 467.635µs ± 0.255µs 467.619µs ± 0.174µs 467.819µs 468.071µs 468.322µs 468.520µs 0.19% 0.331 0.151 0.05% 0.018µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2134381.802op/s 2138418.949op/s ± 1164.591op/s 2138491.766op/s ± 796.867op/s 2139217.758op/s 2140255.192op/s 2140766.119op/s 2141031.069op/s 0.12% -0.328 0.146 0.05% 82.349op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 193.902µs 194.529µs ± 0.290µs 194.538µs ± 0.205µs 194.752µs 194.987µs 195.091µs 195.168µs 0.32% -0.175 -0.557 0.15% 0.020µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5123801.839op/s 5140636.231op/s ± 7658.625op/s 5140372.758op/s ± 5413.110op/s 5145772.455op/s 5153542.729op/s 5157103.742op/s 5157236.682op/s 0.33% 0.181 -0.554 0.15% 541.547op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.383µs 44.586µs ± 0.103µs 44.578µs ± 0.068µs 44.645µs 44.758µs 44.864µs 44.980µs 0.90% 0.881 1.130 0.23% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22231991.774op/s 22428482.786op/s ± 51747.276op/s 22432740.687op/s ± 34141.430op/s 22467040.894op/s 22494727.007op/s 22508480.527op/s 22530977.714op/s 0.44% -0.864 1.077 0.23% 3659.085op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 50.107µs 50.378µs ± 0.248µs 50.272µs ± 0.128µs 50.569µs 50.811µs 51.120µs 51.261µs 1.97% 1.073 0.670 0.49% 0.018µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19507848.733op/s 19850371.467op/s ± 97390.656op/s 19891758.878op/s ± 50690.922op/s 19933241.031op/s 19946729.244op/s 19954407.150op/s 19957147.827op/s 0.33% -1.051 0.587 0.49% 6886.559op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [540.252µs; 540.335µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1850706.000op/s; 1850988.439op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.600µs; 467.671µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2138257.547op/s; 2138580.350op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.489µs; 194.569µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5139574.819op/s; 5141697.643op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.572µs; 44.601µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22421311.111op/s; 22435654.461op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.344µs; 50.413µs] or [-0.068%; +0.068%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19836874.058op/s; 19863868.875op/s] or [-0.068%; +0.068%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.129µs 1.197µs ± 0.024µs 1.206µs ± 0.011µs 1.216µs 1.219µs 1.221µs 1.221µs 1.23% -1.457 1.315 1.99% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.194µs; 1.201µs] or [-0.276%; +0.276%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 252.099µs 267.969µs ± 3.656µs 269.059µs ± 0.620µs 269.594µs 270.450µs 270.732µs 270.834µs 0.66% -3.107 9.394 1.36% 0.259µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3692299.058op/s 3732491.424op/s ± 53199.532op/s 3716654.640op/s ± 8582.084op/s 3726371.780op/s 3858749.803op/s 3963749.417op/s 3966703.491op/s 6.73% 3.179 9.845 1.42% 3761.775op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 22.207µs 22.453µs ± 0.136µs 22.446µs ± 0.112µs 22.557µs 22.697µs 22.751µs 22.797µs 1.57% 0.319 -0.739 0.61% 0.010µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 43864484.823op/s 44540073.175op/s ± 270090.254op/s 44551100.172op/s ± 220442.110op/s 44767163.198op/s 44918885.001op/s 45010027.805op/s 45031028.813op/s 1.08% -0.298 -0.758 0.60% 19098.265op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 13.706µs 13.748µs ± 0.026µs 13.739µs ± 0.016µs 13.765µs 13.798µs 13.822µs 13.840µs 0.73% 0.918 0.482 0.19% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 72255735.960op/s 72739284.928op/s ± 138707.810op/s 72784855.072op/s ± 85901.355op/s 72840997.282op/s 72908184.176op/s 72946510.819op/s 72960747.118op/s 0.24% -0.909 0.456 0.19% 9808.123op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [267.463µs; 268.476µs] or [-0.189%; +0.189%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3725118.481op/s; 3739864.368op/s] or [-0.198%; +0.198%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [22.434µs; 22.471µs] or [-0.084%; +0.084%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [44502641.263op/s; 44577505.086op/s] or [-0.084%; +0.084%] None None None
normalization/normalize_name/normalize_name/good execution_time [13.744µs; 13.751µs] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/good throughput [72720061.360op/s; 72758508.496op/s] or [-0.026%; +0.026%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.398µs 28.307µs ± 13.524µs 21.627µs ± 0.976µs 36.473µs 53.124µs 58.560µs 113.644µs 425.47% 2.568 9.946 47.66% 0.956µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.433µs; 30.182µs] or [-6.621%; +6.621%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.612µs 1.613µs ± 0.001µs 1.613µs ± 0.000µs 1.614µs 1.615µs 1.615µs 1.616µs 0.15% 1.047 0.848 0.04% 0.000µs 1 200
credit_card/is_card_number/ throughput 618852283.085op/s 619795330.838op/s ± 255375.956op/s 619809012.037op/s ± 176588.757op/s 620006424.103op/s 620087036.853op/s 620126606.665op/s 620170952.689op/s 0.06% -1.045 0.841 0.04% 18057.807op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 120.320µs 121.411µs ± 0.363µs 121.406µs ± 0.252µs 121.691µs 121.925µs 122.125µs 122.388µs 0.81% -0.396 0.091 0.30% 0.026µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8170710.758op/s 8236552.343op/s ± 24689.086op/s 8236844.820op/s ± 17126.497op/s 8250634.819op/s 8282759.395op/s 8297032.512op/s 8311166.052op/s 0.90% 0.414 0.107 0.30% 1745.782op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 110.269µs 112.405µs ± 0.503µs 112.393µs ± 0.312µs 112.740µs 113.167µs 113.468µs 113.704µs 1.17% -0.493 1.743 0.45% 0.036µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8794774.916op/s 8896601.793op/s ± 39897.124op/s 8897344.146op/s ± 24728.168op/s 8919201.048op/s 8954389.374op/s 9013831.636op/s 9068760.565op/s 1.93% 0.541 1.866 0.45% 2821.153op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.613µs 1.613µs ± 0.001µs 1.613µs ± 0.000µs 1.614µs 1.615µs 1.615µs 1.621µs 0.50% 4.868 41.204 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 616751213.725op/s 619789598.254op/s ± 317822.371op/s 619858576.635op/s ± 157250.875op/s 619990430.061op/s 620074872.991op/s 620097457.665op/s 620137975.196op/s 0.05% -4.838 40.809 0.05% 22473.435op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 106.087µs 108.612µs ± 0.473µs 108.551µs ± 0.290µs 108.939µs 109.394µs 109.750µs 109.783µs 1.14% -0.612 4.010 0.43% 0.033µs 1 200
credit_card/is_card_number/378282246310005 throughput 9108848.982op/s 9207293.955op/s ± 40180.911op/s 9212245.987op/s ± 24614.990op/s 9231253.516op/s 9257183.858op/s 9284330.219op/s 9426241.887op/s 2.32% 0.687 4.357 0.44% 2841.219op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 110.824µs 111.877µs ± 0.272µs 111.835µs ± 0.142µs 112.000µs 112.373µs 112.669µs 113.108µs 1.14% 0.613 2.993 0.24% 0.019µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 8841131.064op/s 8938440.578op/s ± 21669.814op/s 8941723.215op/s ± 11342.307op/s 8951032.927op/s 8969417.398op/s 8977361.183op/s 9023318.059op/s 0.91% -0.580 2.960 0.24% 1532.287op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 21.751µs 22.316µs ± 0.259µs 22.283µs ± 0.195µs 22.503µs 22.772µs 22.878µs 23.076µs 3.56% 0.420 -0.480 1.16% 0.018µs 1 200
credit_card/is_card_number/x371413321323331 throughput 43334228.392op/s 44817754.638op/s ± 517309.627op/s 44877901.320op/s ± 393857.657op/s 45248510.242op/s 45551926.353op/s 45725477.673op/s 45975246.845op/s 2.45% -0.374 -0.531 1.15% 36579.315op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.612µs 1.613µs ± 0.001µs 1.613µs ± 0.000µs 1.614µs 1.615µs 1.615µs 1.615µs 0.13% 0.858 0.409 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 619075866.958op/s 619821256.311op/s ± 233920.900op/s 619851695.634op/s ± 167901.132op/s 620020370.740op/s 620093034.269op/s 620144179.400op/s 620269419.897op/s 0.07% -0.856 0.404 0.04% 16540.705op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 95.337µs 96.267µs ± 0.304µs 96.327µs ± 0.231µs 96.481µs 96.701µs 96.787µs 96.847µs 0.54% -0.438 -0.298 0.32% 0.021µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10325587.620op/s 10387908.738op/s ± 32853.948op/s 10381304.829op/s ± 24938.368op/s 10412754.063op/s 10446398.254op/s 10469374.015op/s 10489096.483op/s 1.04% 0.452 -0.275 0.32% 2323.125op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 86.155µs 87.791µs ± 0.282µs 87.767µs ± 0.158µs 87.955µs 88.199µs 88.382µs 88.534µs 0.87% -1.339 7.938 0.32% 0.020µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11295133.720op/s 11390769.745op/s ± 36717.260op/s 11393859.865op/s ± 20506.386op/s 11410629.576op/s 11435470.657op/s 11487368.657op/s 11606979.134op/s 1.87% 1.419 8.396 0.32% 2596.302op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.612µs 1.613µs ± 0.001µs 1.613µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.616µs 0.15% 1.035 1.158 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 618927602.843op/s 619817951.820op/s ± 228550.797op/s 619865752.428op/s ± 148113.119op/s 620002998.000op/s 620082533.696op/s 620164706.142op/s 620172193.576op/s 0.05% -1.033 1.150 0.04% 16160.982op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 83.056µs 83.796µs ± 0.227µs 83.773µs ± 0.148µs 83.938µs 84.176µs 84.306µs 84.463µs 0.82% 0.251 0.397 0.27% 0.016µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11839456.964op/s 11933873.725op/s ± 32258.859op/s 11937003.667op/s ± 21110.771op/s 11955224.695op/s 11981686.475op/s 12003817.011op/s 12040123.712op/s 0.86% -0.232 0.397 0.27% 2281.046op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 109.320µs 111.879µs ± 0.365µs 111.874µs ± 0.188µs 112.066µs 112.480µs 112.642µs 112.954µs 0.96% -1.705 12.158 0.33% 0.026µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 8853193.686op/s 8938316.671op/s ± 29367.264op/s 8938623.836op/s ± 15074.798op/s 8953224.334op/s 8972287.511op/s 9006668.101op/s 9147466.304op/s 2.34% 1.818 12.992 0.33% 2076.579op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.762µs 22.363µs ± 0.247µs 22.337µs ± 0.160µs 22.503µs 22.819µs 23.027µs 23.231µs 4.00% 0.660 0.484 1.10% 0.017µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 43045950.734op/s 44721231.541op/s ± 491391.053op/s 44769514.599op/s ± 322503.729op/s 45082167.215op/s 45384746.294op/s 45557588.501op/s 45951465.178op/s 2.64% -0.594 0.357 1.10% 34746.595op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.613µs; 1.614µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/ throughput [619759938.187op/s; 619830723.490op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [121.361µs; 121.461µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8233130.673op/s; 8239974.013op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [112.335µs; 112.474µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 378282246310005 throughput [8891072.435op/s; 8902131.151op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631 execution_time [1.613µs; 1.614µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631 throughput [619745551.130op/s; 619833645.378op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/378282246310005 execution_time [108.546µs; 108.677µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/378282246310005 throughput [9201725.267op/s; 9212862.643op/s] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [111.839µs; 111.915µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [8935437.350op/s; 8941443.806op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.280µs; 22.351µs] or [-0.161%; +0.161%] None None None
credit_card/is_card_number/x371413321323331 throughput [44746060.499op/s; 44889448.777op/s] or [-0.160%; +0.160%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.613µs; 1.613µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ throughput [619788837.124op/s; 619853675.498op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [96.225µs; 96.309µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10383355.496op/s; 10392461.979op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [87.752µs; 87.830µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11385681.086op/s; 11395858.404op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.613µs; 1.613µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [619786276.878op/s; 619849626.763op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [83.764µs; 83.827µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11929402.957op/s; 11938344.492op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [111.828µs; 111.930µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [8934246.651op/s; 8942386.691op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.329µs; 22.398µs] or [-0.153%; +0.153%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [44653129.467op/s; 44789333.615op/s] or [-0.152%; +0.152%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.005ms 9.044ms ± 0.020ms 9.043ms ± 0.007ms 9.050ms 9.062ms 9.073ms 9.261ms 2.41% 6.761 71.405 0.22% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.041ms; 9.047ms] or [-0.030%; +0.030%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.874µs 38.606µs ± 1.180µs 38.080µs ± 0.089µs 38.202µs 41.140µs 41.193µs 41.800µs 9.77% 1.693 0.925 3.05% 0.083µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.442µs; 38.769µs] or [-0.424%; +0.424%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.390µs 3.166µs ± 1.528µs 3.013µs ± 0.021µs 3.034µs 3.086µs 13.757µs 17.388µs 477.15% 7.934 63.442 48.13% 0.108µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.954µs; 3.378µs] or [-6.687%; +6.687%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.882µs 139.705µs ± 0.387µs 139.671µs ± 0.199µs 139.869µs 140.221µs 141.118µs 142.400µs 1.95% 2.278 12.323 0.28% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.651µs; 139.758µs] or [-0.038%; +0.038%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.522µs 70.703µs ± 0.175µs 70.683µs ± 0.047µs 70.738µs 70.835µs 70.989µs 72.891µs 3.12% 9.933 121.443 0.25% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.679µs; 70.727µs] or [-0.034%; +0.034%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 17576b4 1727114791 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 274.279ns 287.890ns ± 14.709ns 282.016ns ± 5.709ns 296.210ns 321.723ns 332.029ns 333.323ns 18.19% 1.513 1.573 5.10% 1.040ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [285.852ns; 289.929ns] or [-0.708%; +0.708%] None None None

Baseline

Omitted due to size.

@alexgallotta alexgallotta marked this pull request as ready for review September 9, 2024 19:58
@alexgallotta alexgallotta requested review from a team as code owners September 9, 2024 19:58
@alexgallotta alexgallotta removed the request for review from purple4reina September 9, 2024 20:01
taegyunkim
taegyunkim requested changes Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint and 3rd party license checks.

taegyunkim
taegyunkim reviewed Sep 10, 2024
View reviewed changes
Comment thread dogstatsd/rust-toolchain.toml Outdated
@alexgallotta alexgallotta force-pushed the upstream-dogstatsd-refactors branch 2 times, most recently from d00227d to f70afed Compare September 11, 2024 23:19
@alexgallotta alexgallotta requested a review from a team as a code owner September 18, 2024 17:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (5635814) to head (17576b4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   73.56%   73.51%   -0.05%     
==========================================
  Files         255      255              
  Lines       36938    36896      -42     
==========================================
- Hits        27173    27125      -48     
- Misses       9765     9771       +6
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.64% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.58% <ø> (ø)
profiling 83.57% <ø> (-0.70%) ⬇️
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <0.00%> (ø)
sidecar 40.10% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.47% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.41% <ø> (ø)

@alexgallotta alexgallotta force-pushed the upstream-dogstatsd-refactors branch from 15f48b7 to 1d71e1c Compare September 18, 2024 17:51
@alexgallotta alexgallotta merged commit af3199a into main Sep 23, 2024
@alexgallotta alexgallotta deleted the upstream-dogstatsd-refactors branch September 23, 2024 19:20
duncanpharvey pushed a commit that referenced this pull request Feb 20, 2025
@alexgallotta @taegyunkim
Upstream dogstatsd refactors (#617)
645b90c 
* feat: upstream dogstatsd from datadog lambda extension

* add: stand alone dogstatsd binary as example

* fix: imports

* fix: make test utils public

* fix: more test utils public

* fix: make entry public

* fix: clippy

* fix: make test config public

* Revert "fix: make test config public"

This reverts commit 7dc9799.

* fix: make fields public for tests and assertions

* refactor: remove unused error

* refactor: do one step parsing

* fix: duplicate dependencies from conflicts

* refactor: use type for sorted tags and ustr

* fix: statsd parsing and tests

* format: format and clippy
test: fix test format with # for tags. It also changed the byte wise
test expected result

* fix: use only minimum regexp

* fix: increase to 10k context size, lost in refactors/moving

* refactor: update license

* fix: remove custom toolchain

* style: fix comment too long not picked up by rustfmt

* fix: restore previous cargo.lock

* fix: missing error dep

* fix: use empty tags

* fix: update license

* fix: nightly rustc 1.83 format

* fix: clippy

* fix: do not use a map, support duplicate tag values

---------

Co-authored-by: Taegyun Kim <[email protected]>
duncanpharvey pushed a commit that referenced this pull request Apr 16, 2025
@alexgallotta @taegyunkim
Upstream dogstatsd refactors (#617)
045f374 
* feat: upstream dogstatsd from datadog lambda extension

* add: stand alone dogstatsd binary as example

* fix: imports

* fix: make test utils public

* fix: more test utils public

* fix: make entry public

* fix: clippy

* fix: make test config public

* Revert "fix: make test config public"

This reverts commit 7dc9799.

* fix: make fields public for tests and assertions

* refactor: remove unused error

* refactor: do one step parsing

* fix: duplicate dependencies from conflicts

* refactor: use type for sorted tags and ustr

* fix: statsd parsing and tests

* format: format and clippy
test: fix test format with # for tags. It also changed the byte wise
test expected result

* fix: use only minimum regexp

* fix: increase to 10k context size, lost in refactors/moving

* refactor: update license

* fix: remove custom toolchain

* style: fix comment too long not picked up by rustfmt

* fix: restore previous cargo.lock

* fix: missing error dep

* fix: use empty tags

* fix: update license

* fix: nightly rustc 1.83 format

* fix: clippy

* fix: do not use a map, support duplicate tag values

---------

Co-authored-by: Taegyun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taegyunkim taegyunkim taegyunkim approved these changes

@astuyve astuyve Awaiting requested review from astuyve

@duncanista duncanista Awaiting requested review from duncanista

@duncanpharvey duncanpharvey Awaiting requested review from duncanpharvey

Assignees

No one assigned

Labels

mini-agent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexgallotta @codecov-commenter @taegyunkim