Bump ddcommon, ddtelemetry, and profiling crates to v4.0.0#236
Merged
Conversation
github-actions
Bot
added
profiling
morrisonlevi
changed the title
ivoanjo
added a commit
that referenced
this pull request
Oct 3, 2023
**What does this PR do?** This PR bumps the libdatadog version to 5.0.0. This PR looks a bit different from previous PRs to bump libdatadog version [(here's the 4.0.0 PR as an example)](#236) because in [this PR](#247) we've centralized the version on the single `Cargo.toml` file. Furthermore, we're going from 4.0.0 to 5.0.0 because there were a number of backwards-incompatible changes to the profiling APIs. **Motivation:** Release libdatadog 5.5.0. **Additional Notes:** If I haven't missed anything, the backwards incompatible API changes were the following: * The value of the `end_timestamp_ns` label is now provided as a regular argument to `ddog_prof_Profile_add` * The libdatadog 5 serializer outputs compressed pprof files * The exporter has a new API that takes two lists, a list of files to compress and a list of files to assume are compressed when exporting * The libdatadog 5 serializer now resets profiles as part of serializing them * The `ddog_prof_Profile_new` now returns a result structure **How to test the change?** I've tested the libdatadog 5 releases using the Ruby profiler, see DataDog/dd-trace-rb#3169 for my draft PR.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps these crates to v4.0.0:
ddcommonandddcommon-ffiddtelemetryandddtelemetry-ffiprofiling,profiling-ffi,profiling-replayerIt does not bump the sidecar*, serverless, nor trace* crates as their version numbers are out-of-sync and I wasn't sure if I should touch them, as I was not involved in any conversations about this.
Motivation
I want to release a new PHP profiler that is based on all the lovely work we did during R&D week.
Additional Notes
This is waiting on #235 to merge, as there is a potential undefined behavior issue there related to
_droproutines.How to test the change?
There are some breaking changes for profiling* crates in here. Upgrade, then test as usual.
For Reviewers
@DataDog/security-design-and-guidance.