Skip to content

feat(stats): emit canonical gRPC status name for OTLP rpc.response.status_code#2183

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
ida613/otlp-rpc-status-name
Jul 1, 2026
Merged

feat(stats): emit canonical gRPC status name for OTLP rpc.response.status_code#2183
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
ida613/otlp-rpc-status-name

Conversation

@mabdinur

Copy link
Copy Markdown
Contributor

Summary

The OTLP trace-metrics path emits the numeric gRPC status code as a string (e.g. "0", "14") for the rpc.response.status_code data-point attribute. The OTel gRPC semantic conventions require the canonical status NAME (e.g. OK, NOT_FOUND, UNAVAILABLE).

This PR maps the numeric code back to the canonical name at OTLP emission only:

  • Adds grpc_status_code_to_name in libdd-trace-stats (span_concentrator), the inverse of the existing grpc_status_str_to_int_value name->code normalization, with the canonical list kept next to the forward table as a single source of truth.
  • libdd-data-pipeline OTLP build_attributes now emits the name (omitting the attribute for empty/unmapped codes).

Why map instead of pass through the raw string?

By the time stats reach the OTLP/agent boundary, grpc.status.code has already been normalized to a numeric u8 in the aggregation key, so the raw name is gone. Mapping the numeric code back to the name reuses that existing normalization and yields the canonical name for every input form ("OK", "ok", "StatusCode.OK", "0", and numeric metrics) without changing the aggregation data model.

Unchanged

  • /v0.6/stats agent payload (encode_grouped_stats still emits the numeric code).
  • The aggregation key (grpc_status_code: Option<u8>) and grouping/cardinality behavior.
  • The SHM (datadog-ipc) path.

Test plan

  • cargo test -p libdd-trace-stats (incl. test_grpc_status_code_to_name)
  • cargo test -p libdd-data-pipeline --lib otlp::metrics (incl. emits_canonical_grpc_status_name_for_rpc_response_status_code)
  • system-tests Test_FR06...::test_fr06_7_rpc_status_code for python once this ships and the python OTLP suite is enabled

Notes

Draft: depends on coordinating the system-tests fr06_7 enablement for python (currently skipped via file-level missing_feature) and a libdatadog bump in dd-trace-py.

Made with Cursor

…atus_code

The OTLP trace-metrics path emitted the numeric gRPC status code as a string for
rpc.response.status_code, but the OTel gRPC semantic conventions require the
canonical status NAME (e.g. OK, NOT_FOUND, UNAVAILABLE).

Add grpc_status_code_to_name in libdd-trace-stats (the inverse of the existing
name->code normalization) and use it at OTLP emission. The /v0.6/stats agent
payload, the aggregation key, and the SHM path are unchanged.

Co-authored-by: Cursor <[email protected]>
@datadog-official

datadog-official Bot commented Jun 30, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 74.34% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: debec9d | Docs | Datadog PR Page | Give us feedback!

@github-actions

Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/ida613/otlp-rpc-status-name

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 1 1 No change (0%)
Total 1 1 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-data-pipeline/src/otlp/metrics.rs 1 1 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 22 22 No change (0%)
datadog-live-debugger 4 4 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-sidecar 45 45 No change (0%)
libdd-common 13 13 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 6 6 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-remote-config 3 3 No change (0%)
libdd-telemetry 20 20 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 3 3 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 11 11 No change (0%)
Total 182 182 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 85.65 MB 85.66 MB +0% (+3.96 KB) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.88 MB 7.88 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 96.82 MB 96.82 MB +0% (+3.58 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.60 MB 10.60 MB +0% (+336 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.41 MB 25.41 MB +0% (+512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.04 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.50 MB 184.51 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 945.48 MB 945.49 MB +0% (+6.48 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.29 MB 8.29 MB +0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.04 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.51 MB 24.51 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.85 MB 48.85 MB +0% (+1.53 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.02 MB 22.02 MB +0% (+1.00 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.51 MB 188.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 932.67 MB 932.68 MB +0% (+6.26 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.41 MB 6.41 MB +0% (+512 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.32 MB 26.32 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 46.48 MB 46.48 MB +0% (+1.26 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.39 MB 76.39 MB +0% (+2.83 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.87 MB 91.87 MB +0% (+2.41 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.66 MB 10.66 MB 0% (0 B) 👌

@mabdinur

Copy link
Copy Markdown
Contributor Author

End-to-end validation (dd-trace-py + system-tests)

Validated this change end-to-end through the Python tracer and the system-tests OTLP trace-metrics parametric suite.

Result: all green

  • test_fr06_7_rpc_status_code[OK | NOT_FOUND | UNAVAILABLE] -> 3 passed
  • Full tests/parametric/test_otlp_trace_metrics.py -> 47 passed

The round-trip works as designed: dd-trace-py sets grpc.status.code="OK" -> libdatadog normalizes name->numeric (0) in aggregation -> the new grpc_status_code_to_name reverse lookup emits the canonical "OK" for rpc.response.status_code at OTLP emission (/v0.6/stats payload and aggregation key unchanged).

Note on how it was built

dd-trace-py (munir/otlp-trace-metrics-export) currently pins libdatadog at the v37.0.0 tag. This branch sits ~5 commits past v37.0.0 (including breaking feat(stats)! changes), and pointing dd-trace-py's native ext directly at it caused transitive dependency drift (a broken hyper 1.9.0) unrelated to this change.

To isolate only this commit for validation, it was cherry-picked onto v37.0.0 (range-diff confirms an identical diff to 8ec3bb982) and dd-trace-py built cleanly against that. No change to the code in this PR is needed -- once this lands on a libdatadog release that dd-trace-py adopts, the behavior validated here applies as-is.

@mabdinur
mabdinur marked this pull request as ready for review June 30, 2026 21:01
@mabdinur
mabdinur requested review from a team as code owners June 30, 2026 21:01
@mabdinur
mabdinur requested review from vpellan and removed request for a team June 30, 2026 21:01
Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs Outdated
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 5e66eb6 into main Jul 1, 2026
110 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the ida613/otlp-rpc-status-name branch July 1, 2026 20:02
iunanua added a commit that referenced this pull request Jul 7, 2026
…ibdd-data-pipeline, libdd-li... (#2201)

# Release proposal for libdd-capabilities-impl, libdd-common,
libdd-data-pipeline, libdd-library-config, libdd-remote-config,
libdd-sampling, libdd-telemetry, libdd-tinybytes, libdd-trace-utils and
their dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `2.1.0`
**Semver bump:** `minor`
**Tag:** `libdd-capabilities-v2.1.0`

### Commits

- feat(data-pipeline)!: add stdout log trace exporter (#2074)

## libdd-common
**Next version:** `5.1.0`
**Semver bump:** `minor`
**Tag:** `libdd-common-v5.1.0`

### Commits

- refactor(clippy): prefer core and alloc imports (#2196)
- fix: update rustls-webpki to 0.103.13 (#2187)
- fix: update anyhow for unsoundness (#2186)
- feat(machine id): Add helpers in ddcommon to fetch the machine UUID l…
(#2163)

## libdd-ddsketch
**Next version:** `1.1.0`
**Semver bump:** `minor`
**Tag:** `libdd-ddsketch-v1.1.0`

### Commits

- feat(data-pipeline)!: export client-computed span stats as OTLP trace
metrics (#2067)
- test(ddsketch): add microbenchmarks for add/encode/collapse (#2125)

## libdd-trace-protobuf
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-protobuf-v4.0.0`

### Commits

- chore!: update protobufs to be in sync with datadog-agent (#2180)
- feat(stats)!: add whole key cardinality limit (#2158)
- feat(remote-config)!: use the proto file from the agent (#2165)
- feat(data-pipeline): OTLP HTTP/protobuf trace export (#2115)

## libdd-capabilities-impl
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.1.0 → ^5.1.0

### Commits

- feat(data-pipeline)!: add stdout log trace exporter (#2074)

## libdd-library-config
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-library-config-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0

### Commits

- refactor(clippy): prefer core and alloc imports (#2196)
- feat(library-config)!: caller-supplied threadlocal schema and extra
process-context attributes (#2162)
- fix(otel-thread-ctx): put the threadlocal attributes at the right
place in the context (#2167)

## libdd-remote-config
**Next version:** `2.0.0`
**Semver bump:** `major`
**Tag:** `libdd-remote-config-v2.0.0`

### ⚠️ major bump forced due to:

- `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0

### Commits

- refactor(libdd-remote-config)!: hide Target inner properties so they
are not leaked (#2182)
- feat(remote-config)!: use the proto file from the agent (#2165)
- refactor(rc): reexport Endpoint and Tag common types (#2147)

## libdd-trace-normalization
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-normalization-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-trace-protobuf`: ^3.0.1 → ^4.0.0

### Commits

- feat(data-pipeline)!: CSS Trace Filters (#1985)

## libdd-shared-runtime
**Next version:** `2.0.0`
**Semver bump:** `major`
**Tag:** `libdd-shared-runtime-v2.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.1.0 → ^5.1.0

### Commits

- feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061)
- feat(shared-runtime)!: use weak waker in trigger [APMSP-3371] (#2050)

## libdd-trace-utils
**Next version:** `9.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v9.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.2.0 → ^5.1.0
- `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0

### Commits

- ci(miri): skip slow miri tests (#2188)
- chore!: update protobufs to be in sync with datadog-agent (#2180)
- feat(data-pipeline): add agentless export (#2081)
- feat(data-pipeline)!: add stdout log trace exporter (#2074)
- feat(data-pipeline): OTLP HTTP/protobuf trace export (#2115)
- feat(otlp)!: Export OTLP spans with attribute-level OTel compatibility
(#2091)
- test(trace-utils): add V05 msgpack decode microbenchmark (#2127)
- feat(data-pipeline)!: export client-computed span stats as OTLP trace
metrics (#2067)
- test(trace-utils): add VecMap microbenchmarks (#2126)
- chore(stats)!: submit p0 telemetry in stats (#2130)
- refactor(change-buffer)!: replace slot index with span_id, fix segment
isolation (#2105)
- feat(data-pipeline)!: CSS Trace Filters (#1985)
- feat(trace-exporter): add v1 span and its encoder (#2039)
- fix(trace-utils): mark decoded span maps as deduped (#2110)
- feat(trace-utils)!: change buffer implementation (#2055)
- feat(native-spans)!: change buffer foundation (#2046)
- refactor(span)!: use VecMap for `meta`, `metrics` and `meta_struct`
for v04 spans (#2043)
- test: fix timeouts on heavily contended scenarios (#2093)

## libdd-telemetry
**Next version:** `6.0.0`
**Semver bump:** `major`
**Tag:** `libdd-telemetry-v6.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.2.0 → ^5.1.0
- `libdd-shared-runtime`: ^1.0.0 → ^2.0.0

### Commits

- ci(miri): skip slow miri tests (#2188)
- refactor(libdd-telemetry)!: avoid leaking libdd-common types in the
public API (#2152)
- feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061)

## libdd-trace-obfuscation
**Next version:** `5.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-obfuscation-v5.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.2.0 → ^5.1.0
- `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0
- `libdd-trace-utils`: ^8.0.0 → ^9.0.0

### Commits

- refactor(clippy): prefer core and alloc imports (#2196)
- ci(miri): skip slow miri tests (#2188)
- fix: update anyhow for unsoundness (#2186)

## libdd-trace-stats
**Next version:** `6.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-stats-v6.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.2.0 → ^5.1.0
- `libdd-shared-runtime`: ^1.0.0 → ^2.0.0
- `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0
- `libdd-trace-utils`: ^8.0.0 → ^9.0.0

### Commits

- chore!: update protobufs to be in sync with datadog-agent (#2180)
- feat(stats)!: send telemetry for cardinality limits (#2159)
- feat(stats)!: add whole key cardinality limit (#2158)
- fix(trace-stats)!: add grpc_method to aggregation key (#2151)
- feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061)
- feat(data-pipeline)!: export client-computed span stats as OTLP trace
metrics (#2067)
- refactor(span)!: use VecMap for `meta`, `metrics` and `meta_struct`
for v04 spans (#2043)

## libdd-data-pipeline
**Next version:** `7.0.0`
**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v7.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.2.0 → ^5.1.0
- `libdd-shared-runtime`: ^1.0.0 → ^2.0.0
- `libdd-telemetry`: ^5.0.1 → ^6.0.0
- `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0
- `libdd-trace-stats`: ^5.0.0 → ^6.0.0
- `libdd-trace-utils`: ^8.0.0 → ^9.0.0

### Commits

- feat(trace_exporter): enable telemetry in stats exporter (#2160)
- refactor(libdd-telemetry)!: avoid leaking libdd-common types in the
public API (#2152)
- feat(stats): emit canonical gRPC status name for OTLP
rpc.response.status_code (#2183)
- feat(data-pipeline): add agentless export (#2081)
- feat(stats)!: send telemetry for cardinality limits (#2159)
- feat(stats)!: add whole key cardinality limit (#2158)
- fix(trace-stats)!: add grpc_method to aggregation key (#2151)
- feat(data-pipeline)!: add stdout log trace exporter (#2074)
- feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061)
- feat(data-pipeline): OTLP HTTP/protobuf trace export (#2115)
- feat(otlp)!: Export OTLP spans with attribute-level OTel compatibility
(#2091)
- feat(data-pipeline)!: export client-computed span stats as OTLP trace
metrics (#2067)
- chore(stats)!: submit p0 telemetry in stats (#2130)
- feat(data-pipeline)!: CSS Trace Filters (#1985)
- feat(shared-runtime)!: use weak waker in trigger [APMSP-3371] (#2050)
- refactor(span)!: use VecMap for `meta`, `metrics` and `meta_struct`
for v04 spans (#2043)
- feat(stats)!: add endpoint gating to client-side stats [APMSP-3361]
(#2040)

## libdd-dogstatsd-client
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-dogstatsd-client-v4.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.1.0 → ^5.1.0


## libdd-sampling
**Next version:** `5.0.0`
**Semver bump:** `major`
**Tag:** `libdd-sampling-v5.0.0`

### ⚠️ major bump forced due to:

- `libdd-common`: ^4.2.0 → ^5.1.0
- `libdd-trace-utils`: ^8.0.0 → ^9.0.0


[APMSP-3371]:
https://datadoghq.atlassian.net/browse/APMSP-3371?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: iunanua <[email protected]>
taegyunkim pushed a commit that referenced this pull request Jul 8, 2026
…atus_code (#2183)

## Summary

The OTLP trace-metrics path emits the numeric gRPC status code as a string (e.g. `"0"`, `"14"`) for the `rpc.response.status_code` data-point attribute. The [OTel gRPC semantic conventions](https://opentelemetry.io/docs/specs/semconv/rpc/grpc/) require the canonical status **NAME** (e.g. `OK`, `NOT_FOUND`, `UNAVAILABLE`).

This PR maps the numeric code back to the canonical name at OTLP emission only:

- Adds `grpc_status_code_to_name` in `libdd-trace-stats` (`span_concentrator`), the inverse of the existing `grpc_status_str_to_int_value` name->code normalization, with the canonical list kept next to the forward table as a single source of truth.
- `libdd-data-pipeline` OTLP `build_attributes` now emits the name (omitting the attribute for empty/unmapped codes).

### Why map instead of pass through the raw string?

By the time stats reach the OTLP/agent boundary, `grpc.status.code` has already been normalized to a numeric `u8` in the aggregation key, so the raw name is gone. Mapping the numeric code back to the name reuses that existing normalization and yields the canonical name for every input form (`"OK"`, `"ok"`, `"StatusCode.OK"`, `"0"`, and numeric metrics) without changing the aggregation data model.

### Unchanged

- `/v0.6/stats` agent payload (`encode_grouped_stats` still emits the numeric code).
- The aggregation key (`grpc_status_code: Option<u8>`) and grouping/cardinality behavior.
- The SHM (`datadog-ipc`) path.

## Test plan

- [x] `cargo test -p libdd-trace-stats` (incl. `test_grpc_status_code_to_name`)
- [x] `cargo test -p libdd-data-pipeline --lib otlp::metrics` (incl. `emits_canonical_grpc_status_name_for_rpc_response_status_code`)
- [ ] system-tests `Test_FR06...::test_fr06_7_rpc_status_code` for python once this ships and the python OTLP suite is enabled

## Notes

Draft: depends on coordinating the system-tests `fr06_7` enablement for python (currently skipped via file-level `missing_feature`) and a libdatadog bump in dd-trace-py.

Made with [Cursor](https://cursor.com)

Co-authored-by: munir.abdinur <[email protected]>
Signed-off-by: Taegyun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants