fix(crashtracker): support socket based receiver for all thread collection#2080
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intoJun 4, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gyuheon0h
changed the title
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
- Coverage 73.58% 73.52% -0.07%
==========================================
Files 470 473 +3
Lines 78449 78551 +102
==========================================
+ Hits 57729 57756 +27
- Misses 20720 20795 +75
🚀 New features to boost your workflow:
|
gyuheon0h
force-pushed
the
gyuheon0h/PROF-14896-sidecar-all-threads-support
branch
2 times, most recently
from
June 4, 2026 14:23
bd67302 to
d0905ea
Compare
gyuheon0h
marked this pull request as ready for review
June 4, 2026 14:54
gyuheon0h
force-pushed
the
gyuheon0h/PROF-14896-incomplete-failed-attach
branch
from
June 4, 2026 14:54
16d9598 to
c7d067b
Compare
gyuheon0h
force-pushed
the
gyuheon0h/PROF-14896-sidecar-all-threads-support
branch
from
June 4, 2026 14:54
d0905ea to
31474f7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31474f7fe9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
gleocadie
approved these changes
Jun 4, 2026
gleocadie
left a comment
gleocadie
left a comment
Contributor
There was a problem hiding this comment.
one comment but overall LGTM
Base automatically changed from
gyuheon0h/PROF-14896-incomplete-failed-attach
to
main
June 4, 2026 15:33
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Jun 4, 2026
a97e1d4
into
main
131 of 135 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
gyuheon0h/PROF-14896-sidecar-all-threads-support
branch
June 4, 2026 16:56
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In crash_handler.rs, PR_SET_PTRACER is only called when receiver.handle.pid is
Some:PHP connects to a pre-existing sidecar process using a Unix socket (
optional_unix_socket_filename).In receiver_manager.rs, the from_socket() path creates a ProcessHandle with pid: None:
If
ptrace_scope=1, since pid isNone,PR_SET_PTRACERis never called. The sidecar then cannot ptrace the crashed process's threads.The fix is to resolve the peer process's PID using
getsockopt(SO_PEERCRED)on the Unix socket fd, then callPR_SET_PTRACERwith that PID.Motivation
I noticed that all PHP crash reports (schema 1.7) have error.threads with 0 frames per thread. Thread names are present (
ddprof_time,ddprof_upload), but stacks are empty with incomplete: false. This affects 100% of PHP crashes. Ruby and Python are unaffected.Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.